Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARLogv, non-variadic version of ARLog, for Swift interop. #279

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Add ARLogv, non-variadic version of ARLog, for Swift interop. #279

merged 2 commits into from
Jun 30, 2016

Conversation

ibrt
Copy link
Contributor

@ibrt ibrt commented Jun 30, 2016

ARLog cannot be called from Swift code because variadic ObjC functions are not supported by the interop layer. I did some research and this seems to be the standard way to go about it (see for example the implementation of NSLog and NSLogv).

@DangerCI
Copy link

DangerCI commented Jun 30, 2016

      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del><p>Please include a CHANGELOG entry. 

You can find it at CHANGELOG.md.


        :white_check_mark: Nice work.
    
  </th>
 </tr>

Generated by 🚫 danger

@orta
Copy link
Owner

orta commented Jun 30, 2016

Cool, looks good, can you add yourself to the CHANGELOG - then we're good to go 👯

@ibrt
Copy link
Contributor Author

ibrt commented Jun 30, 2016

Done, thank you!

@orta
Copy link
Owner

orta commented Jun 30, 2016

Rockin!

@orta orta merged commit 36936b2 into orta:master Jun 30, 2016
@ibrt
Copy link
Contributor Author

ibrt commented Jun 30, 2016

Awesome! Just a quick question, when can I approximately expect the next version to be released?

@orta
Copy link
Owner

orta commented Jun 30, 2016

screen shot 2016-06-30 at 4 45 50 pm

now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants