-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adobe provider screen views with props #247
Adobe provider screen views with props #247
Conversation
@synthemesc - do you have an opinion on this? I don't really know enough about the Adobe SDK to make a call. Otherwise it makes sense to merge |
It would probably break a lot of existing "workflow" with our analytics to do this by default. @arifken, any way you can expose a setting and default to the non-tracking behavior? |
@synthemesc yes definitely, good call. Will do and I'll update the PR |
Updated :) I also added a unit test for the AdobeProvider, and increased the version of OCMock to take advantage of new syntax features. Let me know if you think this is ok. Thanks |
LGTM. +1 |
Ace, @arielelkin - if you can rebase and ping me, I'll happily merge this 👍 |
doh, thanks! |
…or when properties are passed, Added unit test for AdobeProvider
2d54a30
to
80785d2
Compare
rebased! thanks @orta! |
…-props Adobe provider screen views with props
In our Omniture implementation, all screen views have custom properties associated with them. This PR overrides
-didShowNewPageView:withProperties:
to call-trackState:data:
for page views that have custom context data. Without this PR, ARAnalytics triggers an event (-trackAction:data:
). Is this something that would be useful to other developers? or is this too specific to our implementation? Thanks