Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe provider screen views with props #247

Merged
merged 3 commits into from
Feb 10, 2016

Conversation

arifken
Copy link

@arifken arifken commented Jan 12, 2016

In our Omniture implementation, all screen views have custom properties associated with them. This PR overrides -didShowNewPageView:withProperties: to call -trackState:data: for page views that have custom context data. Without this PR, ARAnalytics triggers an event (-trackAction:data:). Is this something that would be useful to other developers? or is this too specific to our implementation? Thanks

@orta
Copy link
Owner

orta commented Jan 13, 2016

Is this something that would be useful to other developers? or is this too specific to our implementation? Thanks

@synthemesc - do you have an opinion on this? I don't really know enough about the Adobe SDK to make a call. Otherwise it makes sense to merge

@synthemesc
Copy link
Contributor

It would probably break a lot of existing "workflow" with our analytics to do this by default. @arifken, any way you can expose a setting and default to the non-tracking behavior?

@arifken
Copy link
Author

arifken commented Jan 19, 2016

@synthemesc yes definitely, good call. Will do and I'll update the PR

@arifken
Copy link
Author

arifken commented Jan 19, 2016

Updated :) I also added a unit test for the AdobeProvider, and increased the version of OCMock to take advantage of new syntax features. Let me know if you think this is ok. Thanks

@synthemesc
Copy link
Contributor

LGTM. +1

@orta
Copy link
Owner

orta commented Feb 8, 2016

Ace, @arielelkin - if you can rebase and ping me, I'll happily merge this 👍

@arielelkin
Copy link
Contributor

@orta you probably mean @arifken :-)

@orta
Copy link
Owner

orta commented Feb 9, 2016

doh, thanks!

@arifken arifken force-pushed the adobe-provider-screen-views-with-props branch from 2d54a30 to 80785d2 Compare February 9, 2016 21:49
@arifken
Copy link
Author

arifken commented Feb 9, 2016

rebased! thanks @orta!

orta added a commit that referenced this pull request Feb 10, 2016
…-props

Adobe provider screen views with props
@orta orta merged commit 72dac16 into orta:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants