Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for key-encrypted metadata in campaign files. Ask the con… #4451

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

pnorbert
Copy link
Contributor

…nection manager for the keys when needed. Ignore datasets for which adios fails to retrieve the valid key (missing or invalid password was given).

eisenhauer
eisenhauer previously approved these changes Jan 29, 2025
…nection manager for the keys when needed. Ignore datasets for which adios fails to retrieve the valid key (missing or invalid password was given).
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except that I would just remove the commented out printfs, this looks good

@pnorbert pnorbert merged commit cb5ed42 into ornladios:master Feb 4, 2025
39 checks passed
@pnorbert
Copy link
Contributor Author

pnorbert commented Feb 5, 2025

I will remove the printf statements when we go out of demo mode to production and settle on useful messages. For now, they are on/off depending on the need of the current demo/tutorial.

@pnorbert pnorbert deleted the campaign_keys branch February 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants