Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evpath: gen_interface.pl support windows #4180

Closed
wants to merge 1 commit into from
Closed

evpath: gen_interface.pl support windows #4180

wants to merge 1 commit into from

Conversation

vicentebolea
Copy link
Collaborator

This has to be merged upstream. NEed this PR for testing and patch

@vicentebolea vicentebolea force-pushed the fix-evpath-codegen-windows branch 2 times, most recently from 7802d9e to dcb5c75 Compare May 27, 2024 20:01
@eisenhauer
Copy link
Member

The unistd.h failure was addressed in a PR. Might need to rebase.

@vicentebolea vicentebolea force-pushed the fix-evpath-codegen-windows branch from dcb5c75 to fb10109 Compare May 27, 2024 20:05
@eisenhauer
Copy link
Member

Let me know and I can merge upstream...

@vicentebolea vicentebolea force-pushed the fix-evpath-codegen-windows branch 3 times, most recently from 43e85d4 to e319793 Compare May 27, 2024 22:37
@vicentebolea vicentebolea force-pushed the fix-evpath-codegen-windows branch from e319793 to c3048fb Compare May 27, 2024 23:06
@vicentebolea
Copy link
Collaborator Author

@eisenhauer thanks! ready for merging upstream. It might be worth to also do some :retab and gg=G in gen_interface.pl.

ParaView finally builds with 5.10 after this change: https://gitlab.kitware.com/paraview/paraview-superbuild/-/merge_requests/1188

@eisenhauer
Copy link
Member

@eisenhauer thanks! ready for merging upstream. It might be worth to also do some :retab and gg=G in gen_interface.pl.

vim is a typo... But yeah, it could probably use a pass through perltidy or something... This code hasn't seen attention in a while.

ParaView finally builds with 5.10 after this change: https://gitlab.kitware.com/paraview/paraview-superbuild/-/merge_requests/1188

Nice!

@vicentebolea
Copy link
Collaborator Author

overseeded by #4181

@vicentebolea vicentebolea deleted the fix-evpath-codegen-windows branch May 28, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicentebolea @eisenhauer