Deactivate campaign recording by default. Use .adios-campaign/ as dir… #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. WRT the windows build failures: Something must have changed in the CI images and now we're failing where we used to pass. I incorporated fixes for this into an Xrootd PR so I could merge it, but that was probably a mistake not do fix that in a separate PR so it could be more easily pulled into release. If you can cherry-pick these commits, it will fix it: 8c62c57 and bdc78df. |
|
I don't find these commits. |
Not sure how best to handle that then... |
|
And failing to do a patch either. |
anagainaru
approved these changes
May 23, 2024
pnorbert
force-pushed
the
fix-adios-campaign-dir
branch
from
0ed08d6 to
85cd036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ectory name. Fixes #4148