pugixml: correct target name

[vicentebolea]

fixes: #4081

[chenrui333]

still seeing the issue after this patch

[ 87%] Linking CXX executable ../../bin/bpls
cd /tmp/adios2-20240405-47102-70bzk3/ADIOS2-2.10.0/build/source/utils && /opt/homebrew/Cellar/cmake/3.29.1/bin/cmake -E cmake_link_script CMakeFiles/bpls.dir/link.txt --verbose=1
/opt/homebrew/Library/Homebrew/shims/mac/super/clang++ -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/bpls.dir/bpls/bpls.cpp.o -o ../../bin/bpls  ../../lib/libadios2_core.2.10.0.dylib
Undefined symbols for architecture arm64:
  "pugi::xml_document::load_buffer(void const*, unsigned long, unsigned int, pugi::xml_encoding)", referenced from:
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
  "pugi::xml_document::xml_document()", referenced from:
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
  "pugi::xml_document::~xml_document()", referenced from:
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
  "pugi::xml_document::save(std::__1::basic_ostream<char, std::__1::char_traits<char>>&, char const*, unsigned int, pugi::xml_encoding) const", referenced from:
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
  "pugi::xml_parse_result::operator bool() const", referenced from:
      adios2::utils::print_data_xml(char const*, unsigned long) in bpls.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[francesco-ballarin]

I had to patch another file as follows (this PR patches source/adios2/toolkit/remote/CMakeLists.txt, but not source/utils/CMakeLists.txt)

diff --git a/source/adios2/toolkit/remote/CMakeLists.txt b/source/adios2/toolkit/remote/CMakeLists.txt
index a739e1a..2128caa 100644
--- a/source/adios2/toolkit/remote/CMakeLists.txt
+++ b/source/adios2/toolkit/remote/CMakeLists.txt
@@ -10,7 +10,7 @@ if (NOT ADIOS2_USE_PIP)
     PRIVATE $<$<PLATFORM_ID:Windows>:shlwapi>)
 
   get_property(pugixml_headers_path
-    TARGET pugixml
+    TARGET adios2::thirdparty::pugixml
     PROPERTY INTERFACE_INCLUDE_DIRECTORIES
   )
 
diff --git a/source/utils/CMakeLists.txt b/source/utils/CMakeLists.txt
index 30dd484..bf57910 100644
--- a/source/utils/CMakeLists.txt
+++ b/source/utils/CMakeLists.txt
@@ -16,7 +16,7 @@ target_link_libraries(bpls
                       PRIVATE $<$<PLATFORM_ID:Windows>:shlwapi>)
 
 get_property(pugixml_headers_path
-  TARGET pugixml
+  TARGET adios2::thirdparty::pugixml
   PROPERTY INTERFACE_INCLUDE_DIRECTORIES
 )
 

to get cmake to run successfully with pugixml provided from debian.

Still, I get a linking error as @chenrui333

/usr/bin/c++ -g -O2 -ffile-prefix-map=/repositories/adios2=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro CMakeFiles/bpls.dir/bpls/bpls.cpp.o -o ../../bin/bpls.serial  ../../lib/x86_64-linux-gnu/libadios2_serial_core.so.2.10.0 -ldl 
/usr/bin/ld: CMakeFiles/bpls.dir/bpls/bpls.cpp.o: undefined reference to symbol '_ZN4pugi12xml_documentD1Ev'
/usr/bin/ld: /lib/x86_64-linux-gnu/libpugixml.so.1: error adding symbols: DSO missing from command line

cc @drew-parsons

[vicentebolea]

@francesco-ballarin can you try this PR #4142

[francesco-ballarin]

Thanks @vicentebolea , I will try the PR, most likely this Saturday.