Don't force initialization for buffers whose contents we will immediately destroy #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnorbert At least a first step not zero-filling buffers that we are immediately going to fill with something else... This change just impacts the BP5 file reader metadata buffer. Turns out that the zero-filling was twice the cost of the metadata installation. The read cost dominated, but this still gets a 5% improvement... |
pnorbert
approved these changes
Feb 9, 2024
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Feb 21, 2024
…tely destroy (ornladios#4031) * BufferMalloc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.