Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix false negative asan checks #3957

Merged
merged 3 commits into from
Dec 7, 2023
Merged

ci: fix false negative asan checks #3957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e5993e
ci: fix path to lsan suppressions, fix broken gh status post
scottwittenburg Dec 6, 2023
f843ae9
Ignore tests with defects for now
scottwittenburg Dec 6, 2023
f21de06
Merge branch 'master' into fix-sanitizer-issues
scottwittenburg Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ defaults: &defaults
steps:
- checkout:
path: source
- run:
# https://discuss.circleci.com/t/circle-working-directory-doesnt-expand/17007
name: "Fix CIRCLE_WORKING_DIRECTORY"
command: echo 'CIRCLE_WORKING_DIRECTORY="${CIRCLE_WORKING_DIRECTORY/#\~/$HOME}"' >> $BASH_ENV
- run:
name: CDash
command: bash source/scripts/ci/circle/postCDashStatus.sh
Expand Down
175 changes: 175 additions & 0 deletions CTestConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,178 @@ set(CTEST_DROP_SITE "open.cdash.org")
set(CTEST_DROP_LOCATION "/submit.php?project=ADIOS")
set(CTEST_DROP_SITE_CDASH TRUE)
set(MEMORYCHECK_SUPPRESSIONS_FILE ${CMAKE_SOURCE_DIR}/scripts/dashboard/nightly/valgrind-suppressions.txt)

# Ignore tests that are currently failing, remove tests here as they are fixed
list(APPEND CTEST_CUSTOM_MEMCHECK_IGNORE
Bindings.C.ADIOS2_C_API.ADIOS2BPWriteTypes.Serial
Bindings.C.BPWriteReadMultiblockCC.ZeroSizeBlocks.Serial
Engine.BP.*/BPAppendAfterStepsP.Test/*.BP5.Serial
Engine.BP.*/BPChangingShapeWithinStep.MultiBlock/*.BP5.Serial
Engine.BP.*/BPParameterSelectStepsP.Read/*.BP5.Serial
Engine.BP.*/BPReadMultithreadedTestP.ReadFile/*.BP5.Serial
Engine.BP.*/BPStepsFileGlobalArrayParameters.EveryOtherStep/*.BP5.Serial
Engine.BP.*/BPStepsFileGlobalArrayReaders.EveryStep/*.BP5.Serial
Engine.BP.*/BPStepsFileGlobalArrayReaders.NewVarPerStep/*.BP5.Serial
Engine.BP.*/BPStepsFileLocalArrayParameters.EveryOtherStep/*.BP5.Serial
Engine.BP.*/BPStepsFileLocalArrayReaders.EveryStep/*.BP5.Serial
Engine.BP.*/BPStepsFileLocalArrayReaders.NewVarPerStep/*.BP5.Serial
Engine.BP.BPChangingShape.BPWriteReadShape2D.BP5.Serial
Engine.BP.BPLargeMetadata.ManyLongStrings.BP5.Serial
Engine.BP.BPWriteAppendReadTestADIOS2.ADIOS2BPWriteAppendRead2D2x4.BP5.Serial
Engine.BP.BPWriteAppendReadTestADIOS2.ADIOS2BPWriteAppendReadAggregate.BP5.Serial
Engine.BP.BPWriteAppendReadTestADIOS2.ADIOS2BPWriteAppendReadVaryingAggregation.BP5.Serial
Engine.BP.BPWriteMultiblockReadTest.ADIOS2BPWriteMultiblockRead1D8.BP5.Serial
Engine.BP.BPWriteMultiblockReadTest.ADIOS2BPWriteMultiblockRead2D2x4.BP5.Serial
Engine.BP.BPWriteMultiblockReadTest.ADIOS2BPWriteMultiblockRead2D4x2.BP5.Serial
Engine.BP.BPWriteMultiblockReadTest.ADIOS2BPWriteRead1D8ZeroBlock.BP5.Serial
Engine.BP.BPWriteReadAsStreamTestADIOS2.ReaderWriterDefineVariable.BP5.Serial
Engine.BP.BPWriteReadAttributes.BPWriteReadSingleTypesVar.BP5.Serial
Engine.BP.BPWriteReadAttributes.WriteReadArrayTypes.BP5.Serial
Engine.BP.BPWriteReadAttributes.WriteReadArrayTypesVar.BP5.Serial
Engine.BP.BPWriteReadAttributes.WriteReadSingleTypes.BP5.Serial
Engine.BP.BPWriteReadAttributes.WriteReadStreamVarp.BP5.Serial
Engine.BP.BPWriteReadAttributeTestMultirank.ADIOS2BPWriteReadArrayTypes.BP5.Serial
Engine.BP.BPWriteReadBlockInfo.BPWriteReadBlockInfo1D8_C.BP3.Serial
Engine.BP.BPWriteReadBlockInfo.BPWriteReadBlockInfo1D8_C.BP4.Serial
Engine.BP.BPWriteReadBlockInfo.BPWriteReadBlockInfo1D8_C.BP5.Serial
Engine.BP.BPWriteReadBlockInfo.BPWriteReadBlockInfo1D8.BP5.Serial
Engine.BP.BPWriteReadBlockInfo.BPWriteReadBlockInfo2D2x4.BP5.Serial
Engine.BP.BPWriteReadLocalVariables.ADIOS2BPWriteReadLocal1DAllSteps.BP5.Serial
Engine.BP.BPWriteReadLocalVariables.ADIOS2BPWriteReadLocal1DBlockInfo.BP5.Serial
Engine.BP.BPWriteReadLocalVariables.ADIOS2BPWriteReadLocal2DChangeCount.BP3.Serial
Engine.BP.BPWriteReadLocalVariables.ADIOS2BPWriteReadLocal2DChangeCount.BP4.Serial
Engine.BP.BPWriteReadLocalVariables.ADIOS2BPWriteReadLocal2DChangeCount.BP5.Serial
Engine.BP.BPWriteReadLocalVariablesSel.BPWriteReadLocal1DAllStepsSel.BP5.Serial
Engine.BP.BPWriteReadLocalVariablesSelHighLevel.BPWriteReadLocal1DAllStepsSel.BP5.Serial
Engine.BP.BPWriteReadMultiblockTest.ADIOS2BPWriteReadMultiblock1D8.BP5.Serial
Engine.BP.BPWriteReadMultiblockTest.ADIOS2BPWriteReadMultiblock2D2x4.BP5.Serial
Engine.BP.BPWriteReadMultiblockTest.ADIOS2BPWriteReadMultiblock2D4x2.BP5.Serial
Engine.BP.BPWriteReadMultiblockTest.MultiblockNullBlocks.BP5.Serial
Engine.BP.BPWriteReadMultiblockTest.MultiblockPerformDataWrite.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead10D2x2.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead10D2x2.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead10D2x2.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead10D2x2.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead10D2x2.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead1D8.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead1D8.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead1D8.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead1D8.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead1D8.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D2x4.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D2x4.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D2x4.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D2x4.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D2x4.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ADIOS2BPWriteRead2D4x2.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.GetDeferredInClose.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.GetDeferredInClose.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.GetDeferredInClose.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.GetDeferredInClose.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.GetDeferredInClose.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2.ReadStartCount.Async.BP5.EWS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ReadStartCount.Async.BP5.EWS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ReadStartCount.Async.BP5.TLS.Guided.Serial
Engine.BP.BPWriteReadTestADIOS2.ReadStartCount.Async.BP5.TLS.Naive.Serial
Engine.BP.BPWriteReadTestADIOS2.ReadStartCount.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2fstream.ADIOS2BPWriteRead1D8.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2fstream.ADIOS2BPWriteRead2D2x4.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2fstream.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2fstream.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2fstream.ADIOS2BPWriteRead2D4x2.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2stdio.ADIOS2BPWriteRead1D8.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2stdio.ADIOS2BPWriteRead2D2x4.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2stdio.ADIOS2BPWriteRead2D4x2_MultiStepsOverflow.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2stdio.ADIOS2BPWriteRead2D4x2_ReadMultiSteps.BP5.Serial
Engine.BP.BPWriteReadTestADIOS2stdio.ADIOS2BPWriteRead2D4x2.BP5.Serial
Engine.BP.BPWriteReadVector.ADIOS2BPWriteRead1D8.BP5.Serial
Engine.BP.BPWriteReadVector.ADIOS2BPWriteRead2D2x4.BP5.Serial
Engine.BP.BPWriteReadVector.ADIOS2BPWriteRead2D4x2.BP5.Serial
Engine.BP.BPWriteReadVector.ADIOS2BPWriteReadVector2D4x2_MultiSteps.BP5.Serial
Engine.BPEngineTest.ZfpComplex.Serial
Engine.SST.SstWriteFails.InvalidBeginStep.Serial
Engine.SST.SstWriteFails.InvalidPut.Serial
Engine.Staging.TestThreads.Basic.SST.BP.Serial
Engine.Staging.TestThreads.Basic.SST.FFS.Serial
Interface.ADIOS2_CXX11_API_Selection.MemorySelectionComplex.BPfile.Serial
Interface.ADIOS2_CXX11_API_Selection.MemorySelectionReadStart.BPfile.Serial
Remote.BPWriteMemorySelectionRead.FileRemote
Remote.BPWriteMemorySelectionRead.GetRemote
Remote.BPWriteReadADIOS2stdio.GetRemote
remoteServerCleanup
remoteServerSetup
Staging.1x1.Attrs.BP5
Staging.1x1.Attrs.CommMin.BP.SST
Staging.1x1.Attrs.CommMin.BP5.SST
Staging.1x1.CommMin.BP.SST
Staging.1x1.CommMin.BP5.SST
Staging.1x1.ForcePreload.CommMin.BP.SST
Staging.1x1.ForcePreload.CommMin.BP5.SST
Staging.1x1.Local2.CommMin.BP.SST
Staging.1x1.Local2.CommMin.BP5.SST
Staging.1x1.LocalMultiblock.CommMin.BP.SST
Staging.1x1.LocalMultiblock.CommMin.BP5.SST
Staging.1x1.ModAttrs.BP5
Staging.1x1.ModAttrs.CommMin.BP.SST
Staging.1x1.ModAttrs.CommMin.BP5.SST
Staging.1x1.NoPreload.CommMin.BP.SST
Staging.1x1.NoPreload.CommMin.BP5.SST
Staging.1x1.SstRUDP.CommMin.BP.SST
Staging.1x1.SstRUDP.CommMin.BP5.SST
Staging.1x1Joined.BP5
Staging.1x1Joined.CommMin.BP5.SST
Staging.1x1LockGeometry.CommMin.BP.SST
Staging.1x1LockGeometry.CommMin.BP5.SST
Staging.1x1Struct.BP5
Staging.1x1Struct.CommMin.BP5.SST
Staging.1x1VarDestruction.CommMin.BP.SST
Staging.1x1VarDestruction.CommMin.BP5.SST
Staging.AllToAllDistribution.1x1x3.CommMin.BP.SST
Staging.AllToAllDistribution.1x1x3.CommMin.BP5.SST
Staging.DiscardWriter.1x1.CommMin.BP.SST
Staging.DiscardWriter.1x1.CommMin.BP5.SST
Staging.LatestReader.1x1.CommMin.BP.SST
Staging.LatestReader.1x1.CommMin.BP5.SST
Staging.LatestReaderHold.1x1.CommMin.BP.SST
Staging.LatestReaderHold.1x1.CommMin.BP5.SST
Staging.OnDemandSingle.1x1.CommMin.BP.SST
Staging.OnDemandSingle.1x1.CommMin.BP5.SST
Staging.RoundRobinDistribution.1x1x3.CommMin.BP.SST
Staging.RoundRobinDistribution.1x1x3.CommMin.BP5.SST
Staging.TimeoutReader.1x1.CommMin.BP.SST
Staging.TimeoutReader.1x1.CommMin.BP5.SST
Staging.WriteMemorySelectionRead.1x1.CommMin.BP.SST
Staging.WriteMemorySelectionRead.1x1.CommMin.BP5.SST
Staging.ZFPCompression.1x1.CommMin.BP.SST
Staging.ZFPCompression.1x1.CommMin.BP5.SST
Staging.ZFPCompression.3x5.CommMin.BP.SST
Staging.ZFPCompression.3x5.CommMin.BP5.SST
Utils.ChangingShape.AlternatingStepsAndChangingShapeVar.Dump
Utils.ChangingShape.AlternatingStepsVarSelection.Dump
Utils.ChangingShape.ChangingShapeVarOneStep.Dump
Utils.ChangingShape.Dump
Utils.ChangingShape.FixedShapeVarTooManySteps.Dump
Utils.ChangingShape.Screen
Utils.CWriter
Utils.CWriter.Bpls.Al.Dump
Utils.CWriter.Bpls.h.Dump
Utils.CWriter.Bpls.la.Dump
Utils.CWriter.Bpls.la.Screen
Utils.CWriter.Bpls.ldDav.Dump
Utils.CWriter.Bpls.ldDavvv.Dump
Utils.CWriter.Bpls.ldvarI16.Dump
)
2 changes: 1 addition & 1 deletion scripts/ci/circle/postCDashStatus.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build_status_body() {
EOF
}

PYTHON_SCRIPT="${SOURCE_DIR}/scripts/ci/findStatus.py"
PYTHON_SCRIPT="${SOURCE_DIR}/scripts/ci/circle/findStatus.py"
curl -u "${USER}:${TOKEN}" "${API_BASE}/commits/${COMMIT}/statuses" | python3 "${PYTHON_SCRIPT}" --context ${CDASH_STATUS_CONTEXT}
exit_status=$?
if [ "$exit_status" -ne 0 ]
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/cmake/ci-fedora-asan.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set(ENV{CC} clang)
set(ENV{CXX} clang++)
set(ASAN_FLAGS "-fsanitize=address -fno-omit-frame-pointer -pthread -mllvm -asan-use-private-alias=1 -Wno-unused-command-line-argument")
set(ENV{ASAN_OPTIONS} "use_odr_indicator=1")
set(ENV{LSAN_OPTIONS} "suppressions=${CMAKE_SOURCE_DIR}/thirdparty/perfstubs/perfstubs.supp")
set(ENV{LSAN_OPTIONS} "suppressions=$ENV{CI_SOURCE_DIR}/thirdparty/perfstubs/perfstubs.supp")
set(ENV{CFLAGS} "${ASAN_FLAGS}")
set(ENV{CXXFLAGS} "${ASAN_FLAGS}")

Expand Down
Loading