Misc fixes #3768
Merged
Misc fixes #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merging without review since it is a small change in the CI and I need it to be merged in order be tested. I take full responsibility of its impact 👼 |
|
Here are the previous sizes from my local images list, it seems the new ones are smaller 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scottwittenburg
According to the build progress output the steps takes around 900s in my computer. The new base image size is 3.84GiB, I cannot check accurately how big was the previous image since I accidentally override it. IF you still have it in your docker instance can you report how much is from sudo docker images.
Another unrelated change: Removed gitattribute file from KWsys since it somehow breaks our git worktree. We did the same few years ago when we updated kwsys project.