Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Flush Test for BP5 #3683

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Enable Flush Test for BP5 #3683

merged 2 commits into from
Aug 1, 2023

Conversation

eisenhauer
Copy link
Member

No description provided.

@eisenhauer eisenhauer requested a review from vicentebolea as a code owner July 3, 2023 13:23
@vicentebolea vicentebolea removed their request for review July 3, 2023 15:40
@eisenhauer eisenhauer force-pushed the FlushTest branch 2 times, most recently from 38678a3 to 6a1b68e Compare July 3, 2023 16:13
@eisenhauer eisenhauer enabled auto-merge July 3, 2023 17:46
@eisenhauer eisenhauer requested a review from pnorbert July 6, 2023 16:10
anagainaru
anagainaru previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if you need specifically Norbert to look at this, but it looks fine to me so if you just need a review I'll approve it

@eisenhauer
Copy link
Member Author

I am not sure if you need specifically Norbert to look at this, but it looks fine to me so if you just need a review I'll approve it

Thanks! I had forgotten about this one. Rebasing on current master.

@eisenhauer eisenhauer disabled auto-merge August 1, 2023 12:59
@eisenhauer eisenhauer requested a review from anagainaru August 1, 2023 13:56
@eisenhauer
Copy link
Member Author

And of course force-pushing blows away the approval, so requesting again...

@eisenhauer eisenhauer merged commit 4c3e1ba into ornladios:master Aug 1, 2023
@eisenhauer eisenhauer deleted the FlushTest branch August 1, 2023 14:08
@BrewTestBot BrewTestBot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnorbert pnorbert Awaiting requested review from pnorbert

@anagainaru anagainaru Awaiting requested review from anagainaru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eisenhauer @anagainaru