Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports bp5 bugfix #3619

Merged

Conversation

vicentebolea
Copy link
Collaborator

No description provided.

@vicentebolea vicentebolea requested a review from eisenhauer May 12, 2023 16:29
@vicentebolea vicentebolea marked this pull request as ready for review May 12, 2023 16:29
@vicentebolea
Copy link
Collaborator Author

I added the OLCF ascent commit to get status check for BP5 in XL, we can remove it (or not) before merging.

eisenhauer
eisenhauer previously approved these changes May 12, 2023
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BP5 changes look good.

@vicentebolea
Copy link
Collaborator Author

Hopefully XL passing 🤞

@vicentebolea
Copy link
Collaborator Author

@eisenhauer nice :), do you think it is a good idea to bring the OLCF Ascent changes to the release? There are all aditions of CI files, no CMake or source code touched.

(cherry picked from commit 5012782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants