Adding missing HIP specific functionality #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
force-pushed
the
hip-specific-func
branch
from
ee236aa to
a17eda2
Compare
eisenhauer
approved these changes
May 9, 2023
|
@anagainaru We will add a nightly build that runs in Crusher soon. How about merging this in master, mark it as 2.9.1 backport, and after we pass the build in Crusher with GPU we backport this. The reason is that we might want to change more things in this area again once we test this in Crusher so we can skip the trouble of double backporting then. |
|
@vicentebolea sorry I saw this too late. I will do that for my next PR (unless it's after you add the nightly build) |
No problem, these things happens. We will have the crusher build soon 🎉 |
vicentebolea
pushed a commit
that referenced
this pull request
May 11, 2023
Adding missing HIP specific functionality
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing functionality to set the device id and to check if a buffer is allocated on the GPU for the HIP backend. The tests are passing because the memory space is set manually. This needs to be included in the patch for the latest release.