Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: set correct soname #3585

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

vicentebolea
Copy link
Collaborator

In the installation tree, we need to set the soname/version of our third library same as our ADIOS soname/soversion. This is needed for package manager to deal with multiple versions of ADIOS installed in their system.

@vicentebolea vicentebolea force-pushed the fix-soname branch 2 times, most recently from b72dc49 to 68c68d2 Compare April 11, 2023 18:02
@eisenhauer
Copy link
Member

Huh. Isn't this potentially going to mess things up internally? For example, evpath/CMakeLists looks for versions of ffs and atl:
find_package(atl 2.2.1 REQUIRED)
find_package(ffs 2.0.0 REQUIRED)

Also, when you run the update.sh script, in those thirdparty libraries will it wipe your changes to their CMakeLists.txt?

@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Apr 11, 2023

@eisenhauer good question

For example, evpath/CMakeLists looks for versions of ffs and atl:

This should not be a problem since we are not changing the version of those packages only the versions of their shared library. This is same as if we have a share library with a different naming, nothing will change internally (or externally, if that library name change is reflected the pkg-config.cmake (or targets) file.

The original problem with package managers is that if you have lets say adios2.8.3 and adios 2.9.0 installed now since those thirdparty libraries potentially have the same name/version problems arises of who owns it.

Also, when you run the update.sh script, in those thirdparty libraries will it wipe your changes to their CMakeLists.txt?

Yep, but I made every change outside of the folder that gets wiped (in the case of perfstubs, its cmakelists is set as an expection not to be wipe, upstream does not have a cmakelists.txt actually)

@vicentebolea vicentebolea merged commit 240690a into ornladios:master Apr 11, 2023
@vicentebolea vicentebolea deleted the fix-soname branch April 11, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants