-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestBPChangingShapeWithinStep without and with various compressors #3577
TestBPChangingShapeWithinStep without and with various compressors #3577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know we support this. Maybe we can test this for MGARD as well.
New test now works with blosc, mgard and zfp (CPU-only) if they are available. |
I did not dismiss your review, nor requested new review. Was automatic somehow |
Yes I am in the codeowner file for the cmake files. I think I have to limit it so I am not asked to review everywhere haha. It was good during the release but not needed anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha yes, whenever you push a new commit, the reviews are voided :) Approving again, looks good to me.
231c82d
to
3c8cffa
Compare
rebased with master |
47ec16c
to
56b94d8
Compare
Cleaned-up the commit history after fixing the build on windows. Ready for review and merge after passing the tests. |
56b94d8
to
99dc7e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it one last time
…ressors to it if they are available (blosc, mgard, zfp). Tests: Engine.BP.*/BPChangingShapeWithinStep.MultiBlock/*.
99dc7e0
to
8bbdefa
Compare
…on turned on. This is an openPMD use case that needs to be checked.