If BP5 parameter Threads is 0 (default), calculate the number of thre… #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads from the available hardware threads and number of processes per compute node, but limit to 16 max. Added doc.
…t guaranteed to be thread-safe. Fix Engine.BP.WriteAppendReadADIOS2 test where one variable was put twice, leading to simultaneous memcpy calls on the same target memory at reading. Note: The current multithreaded read in BP5 leads to concurrent memcpy calls under NdCopy(). If two blocks in the dataset refer to the same cell in space, there could be data race in two memcpy() calls to put the same cell's value from two incoming blocks. By definition, which value ends up in the read result, is undefined, so as long as the two memcpy calls will result in one of the values placed, it is all good. However, if concurrent memcpy calls result in random unrelated values placed in memory, then the read result would be invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ads from the available hardware threads and number of processes per compute node, but limit to 16 max. Added doc.