Fix a template instantiation issue with GCC 10 in dataman serializer #3155
Conversation
JasonRuonanWang
changed the title
| endif() | ||
| if(DATASPACES_FOUND) | ||
| set(ADIOS2_HAVE_DataSpaces TRUE) | ||
| if(MPI_FOUND) |
There was a problem hiding this comment.
@JasonRuonanWang does DataSpaces not work without MPI?
The Engine.DataMan.DataManEngineTest.1D.Serial test seems to suggest so.
There was a problem hiding this comment.
ah wait, I mismatched DataMan and DataSpaces.
I guess this change in CMake could better have been a separate PR :)
There was a problem hiding this comment.
ah wait, I mismatched
DataManandDataSpaces.
I guess this change in CMake could better have been a separate PR :)
In principle, yes. But cmake does not pass if DataSpaces libraries are found and MPI is disabled. This is something that must be fixed anyway in order to reproduce the error. I could have opened another PR but it would just waste another few hours before getting the problem solved. Given the amount of work I have on my desk, I'd rather compromise on these trivial things, unless someone else is willing to help separate the PRs and get them merged in a perfect way.
There was a problem hiding this comment.
Sure, sounds good. I was just confused for a sec, sorry for that :)
|
@chuckatkins This PR needs to be pulled into master too. Thanks. |
|
Should |
Fixes #3151
It seems that GCC 10 handles template instantiation differently from previous GCC versions, and as a result, some template instantiation in DataMan serializer failed to pick up the correct template instantiation. This PR changed the affected template instantiation to simple function overloading.