Redirect f2c to correct call #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am playing with the example provided in #2472 and there is a test for it, Bindings.Fortran.BPWriteTypes.Serial` |
|
Yes, it fixes it. Thanks. |
pnorbert
approved these changes
Sep 29, 2020
|
Ahh, the test just prints the nsteps if it is not correct, but does not fail. |
|
adios2/bindings/fortran/TestBPWriteTypes.F90: 234 |
|
@pnorbert great catch. Now, I'm wondering what exactly I was trying to do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2472 @pnorbert looks like a terrible oversight from my side, the Fortran bindings need more testing on the read side.