Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5 vol #2453

Merged
merged 10 commits into from
Jan 5, 2021
Merged

H5 vol #2453

merged 10 commits into from
Jan 5, 2021

Conversation

guj
Copy link
Contributor

@guj guj commented Sep 3, 2020

No description provided.

@guj
Copy link
Contributor Author

guj commented Sep 4, 2020

Hi @chuckatkins
Finally pull request is successful. Handing this over to you to see what is the best way to distribute.
And yes, dynamic loading works, just set 2 env variables.

@chuckatkins
Copy link
Contributor

Was there a need to write the whole thing in C rather than C++ and just extern "C" the api that hdf needs?

@guj
Copy link
Contributor Author

guj commented Sep 4, 2020

Was there a need to write the whole thing in C rather than C++ and just extern "C" the api that hdf needs?

I am used to write in C when using hdf5.. Just a habit..

@chuckatkins chuckatkins added this to the 2.7.0 Release milestone Dec 23, 2020
@chuckatkins chuckatkins changed the base branch from master to release_27 December 23, 2020 20:35
@chuckatkins chuckatkins self-assigned this Dec 23, 2020
@chuckatkins chuckatkins added enhancement status: work-in-progress This issue is actively being worked on triage: high This issue is a blocker and has to be addressed before the next release or milestone labels Dec 23, 2020
@chuckatkins
Copy link
Contributor

@guj it looks like when rebased on the current master / release there's a build failure. If you can resolve that issue then I can work through the rest of the code and cmake re-organization.

@guj
Copy link
Contributor Author

guj commented Dec 27, 2020

@guj it looks like when rebased on the current master / release there's a build failure. If you can resolve that issue then I can work through the rest of the code and cmake re-organization.

done.

@chuckatkins
Copy link
Contributor

@guj Reorg of build complete. Please take a look. The example you had was too brittle to use as an actual test so please add some proper tests in testing/h5vol; you can test for it's enabling via the CMake variable ADIOS2_HAVE_HDF5_VOL.

@guj
Copy link
Contributor Author

guj commented Jan 4, 2021

@guj Reorg of build complete. Please take a look. The example you had was too brittle to use as an actual test so please add some proper tests in testing/h5vol; you can test for it's enabling via the CMake variable ADIOS2_HAVE_HDF5_VOL.

done!

@chuckatkins chuckatkins merged commit dfe10ef into ornladios:release_27 Jan 5, 2021
chuckatkins pushed a commit that referenced this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement status: work-in-progress This issue is actively being worked on triage: high This issue is a blocker and has to be addressed before the next release or milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants