Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation. #2371

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Update documentation. #2371

merged 3 commits into from
Jul 10, 2020

Conversation

NAThompson
Copy link
Contributor

  • Joined arrays have been implemented.
  • Follow documentation advice by using fixed width types in the docs.
  • Properly typeset more code calls.

NAThompson added 2 commits July 9, 2020 17:13
@NAThompson
Update documentation.
19aa3a3 
- Joined arrays have been implemented.
- Follow documentation advice by using fixed width types in the docs.
- Properly typeset more code calls.
@NAThompson
Local variable reads are supported.
3140b23
@pnorbert
Copy link
Contributor

Actually, I don't find a single test which tests Joined Arrays. There are some interface tests for defining them (not writing them), but the secret sauce is in reading back arrays written like this.

@NAThompson
Copy link
Contributor Author

@pnorbert : Nice catch, I only looked through the source and bindings for joined array code paths.

@pnorbert pnorbert merged commit 54cca3e into ornladios:master Jul 10, 2020
@NAThompson NAThompson deleted the docs_updates_2 branch July 10, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NAThompson @pnorbert