-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performputs buffersize #2326
Fix performputs buffersize #2326
Conversation
@chuckatkins This test writes 3 datasets, each 721MB (and does this twice testing BP3 and BP4). The dataset is a side effect only, so we could remove each immediately after writing, but testing has no access to thirdparty ( |
@chuckatkins NVM for this test, now it uses NULL transport to avoid writing to disk at all. |
@chuckatkins @bradking Do you guys have an idea why the sanitizers fail to run this new test?
|
Cc: @KyleFromKitware |
@pnorbert We should have the capacity on the test VMs for a 2.1gb working set, so long as it's removed after the test. The way to accomplish that is through test fixtures. See the docs here for how to use it: https://cmake.org/cmake/help/v3.7/prop_test/FIXTURES_REQUIRED.html But essentially it's just:
|
…datasize correctly in case of multiple calls of PerformPuts(). Addresses ornladios#2320
- profile is written as <filename.bp>_profiling.json if only a NULL transport is used - TestBPBufferSize now uses NULL transport to avoid writing lots of data to disk
9edcdbd
to
39a545f
Compare
…datasize correctly in case of multiple calls of PerformPuts(). Addresses #2320