Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak from CompressZFP. #1977

Merged
merged 4 commits into from
Feb 21, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CI: Add ZFP to the AddressSanitizer build
Chuck Atkins authored and NAThompson committed Feb 21, 2020
commit 41ec6fa0f1c97d7492e34e7f5daff8ad5b914c77
12 changes: 5 additions & 7 deletions scripts/ci/cmake/ci-fedora-asan.cmake
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
# Client maintainer: [email protected]

set(ENV{CC} gcc)
set(ENV{CXX} g++)
set(ENV{FC} gfortran)
set(ASAN_FLAGS "-fsanitize=address -pthread")
set(ENV{CC} clang)
set(ENV{CXX} clang++)
set(ASAN_FLAGS "-fsanitize=address -fno-omit-frame-pointer -pthread")
set(ENV{CFLAGS} "${ASAN_FLAGS}")
set(ENV{CXXFLAGS} "${ASAN_FLAGS}")
set(ENV{FFLAGS} "${ASAN_FLAGS}")

set(dashboard_cache "
ADIOS2_USE_Fortran:STRING=OFF
ADIOS2_USE_HDF5:STRING=ON
ADIOS2_USE_MPI:STRING=OFF
ADIOS2_USE_Python:STRING=OFF
HDF5_C_COMPILER_EXECUTABLE:FILEPATH=/usr/bin/h5cc
HDF5_DIFF_EXECUTABLE:FILEPATH=/usr/bin/h5diff
ADIOS2_USE_ZFP:STRING=ON
")

set(dashboard_track "Analysis")
13 changes: 13 additions & 0 deletions scripts/ci/images/fedora-asan/Dockerfile
Original file line number Diff line number Diff line change
@@ -3,6 +3,19 @@ FROM ornladios/adios2:fedora-sanitizers-base
# Install core dev packages
RUN dnf -y install libasan python3-devel python3-numpy hdf5-devel

# Install ZFP
WORKDIR /opt/zfp
RUN curl -L https://github.com/LLNL/zfp/releases/download/0.5.5/zfp-0.5.5.tar.gz | tar -xvz && \
mkdir build && \
cd build && \
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/opt/zfp/0.5.5 ../zfp-0.5.5 && \
make -j$(grep -c '^processor' /proc/cpuinfo) install && \
cd .. && \
rm -rf zfp-0.5.5 build
ENV PATH=/opt/zfp/0.5.5/bin:${PATH} \
LD_LIBRARY_PATH=/opt/zfp/0.5.5/lib64:${LD_LIBRARY_PATH} \
CMAKE_PREFIX_PATH=/opt/zfp/0.5.5:${CMAKE_PREFIX_PATH}

# Misc cleanup
RUN dnf clean all && \
rm -rfv /tmp/* /var/cache/dnf