Complex long double support in hdf5 #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! I added its commits to #1907 :) |
5 tasks
ax3l
reviewed
Dec 28, 2019
| m_PropertyTxfID = H5Pcreate(H5P_DATASET_XFER); | ||
| } | ||
|
|
||
| HDF5Common::~HDF5Common() | ||
| { | ||
| H5Tclose(m_DefH5TypeComplexLongDouble); |
There was a problem hiding this comment.
@guj this seams to write some H5Tclose(): not a datatype errors to stderr in some tests.
changed complex fileds to r/i per Axel's suggestion
otherwise they are somewhat cleaned up after H5Fclose and causes error if trying to call H5Tclose on these compound types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.