Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate mpi/nompi bpwriter examples into single sources for each #1849

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

chuckatkins
Copy link
Contributor

No description provided.

@chuckatkins
Copy link
Contributor Author

@williamfgc I wasn't sure how to adjust the fortran examples since I don't think the ADIOS2_HAVE_* preprocesser definitions are exposed through the module. If you know of a good way to achieve a single source for the fortran example I'd welcome it.

@williamfgc
Copy link
Contributor

@chuckatkins yes, I don't know of a good way since the Fortran 90 pre-processor is not a standard/portable thing (gfortran uses -cpp and ifort uses -fpp to turn it on), but I am not sure ADIOS2_HAVE_* is automatically exposed. We could always compile and run mpi and "no-mpi (but mpi linked)" code now (e.g. bpls). BTW, thanks for doing this.

@chuckatkins chuckatkins force-pushed the combine-nompi-examples branch from 5f85f31 to 6729179 Compare October 31, 2019 16:01
@chuckatkins
Copy link
Contributor Author

From what I've been able to find it seems that if the .F90 extension is used rather than .f90 then most Fortran compilers invoke fpp by convention. See updated commit.

@williamfgc
Copy link
Contributor

@chuckatkins sounds great.

@chuckatkins chuckatkins merged commit 4bf7f97 into ornladios:master Oct 31, 2019
@chuckatkins chuckatkins deleted the combine-nompi-examples branch October 31, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants