-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes IsReverseDims in BlockInfo #1573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a general comment is that since IsReverseDims
will always be the same across all blocks in a Variable, I'd prefer to have it exposed on a per-Variable basis, not per-Block. Most readers / viz apps will probably not naturally use the block-based API.
@@ -348,6 +348,8 @@ class Variable | |||
size_t Step = 0; | |||
/** reference to internal block data (used by inline Engine) */ | |||
const T *Data() const; | |||
/** true: Dims were swapped from column-major, false: not swapped */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment: dims may also have been swapped from row-major to col-major, when reading from Fortran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germasch this particular struct is only exposed in the C++11 bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1553 (comment)
I don't want to push this in the release. We need some time to get it right and work with the apps that need it (both vis and simulations). It's a new feature with only a day left to the release. Let's go ahead and put this in master instead for now so it will be there but still give us time to refine it for the next release.
@williamfgc please edit the PR to target |
@chuckatkins fine with me, just doing this for you and @berkgeveci |
request in #1553 |
related to request in #1553 from @berkgeveci