testing: expose a bug #1293
Merged
testing: expose a bug #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a proper automated test, as it requrires manual bpls afterwards to see the issue.
|
Rebased, cleaned up, automated. I still get one failure locally. |
germasch
force-pushed
the
pr/bug
branch
4 times, most recently
from
d3179a8 to
adf0be8
Compare
williamfgc
reviewed
Mar 16, 2019
| {{rank * Nx}, {Nx / 2}}, {{rank * Nx + Nx / 2}, {Nx / 2}}, | ||
| }; | ||
|
|
||
| io.SetParameter("MaxBufferSize", "50"); |
There was a problem hiding this comment.
@germasch please follow the exception message, you need units (Gb, Mb, Kb)
| PopulateBlock(myData, b); | ||
| } | ||
|
|
||
| engine.Put(var, std::vector<T>{5., 6., 7., 8., 9.}.data(), |
There was a problem hiding this comment.
This is interesting, it's an address vector.data(), to a r-value. We'll have to test this one.
|
I will merge this and look at it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this here not because I want it merged, but because it shows a bug.
This isn't a proper automated test, as it requrires manual bpls afterwards
to see the issue.
See #1292 .