Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple read request for one variable #335

Closed
guj opened this issue Dec 5, 2017 · 3 comments
Closed

support multiple read request for one variable #335

guj opened this issue Dec 5, 2017 · 3 comments
Assignees
@williamfgc
Labels
enhancement

Comments

@guj
Copy link
Contributor

guj commented Dec 5, 2017

Need to support multiple selection in the Variable class
so it is possible to schedule multiple GetDefered() requests on that variable.

Right now client has to union different selections or do GetSync()
if they want to read data from 2 different boundingboxes for the same variable
@pnorbert
Copy link
Contributor

pnorbert commented Dec 7, 2017

We need an example for this. It should work this way:
var.SetSelection()
engine.GetDeferred()
var.SetSelection()
engine.GetDeferred()
engine.PerformGets()

@eisenhauer
Copy link
Member

Let me add that we need the same thing with PutDeferred() on the write side... (And Norbert, I would encourage a test and not just an example! (You probably meant example in the looser sense, but just to clarify...))

williamfgc added a commit to williamfgc/ADIOS2 that referenced this issue Jun 4, 2018
@williamfgc
Write side Put multiblock
686a9f6 
Related to ornladios#335
Refactored BP3 Serializer to allow multiblock
Added multiblock info data structure in Variable
DefineVariable pointer removed for type except in Python
APIs: numpy array or string in define variable.
Tests added

TO DO:
    read multiblock (separate branch)
@williamfgc williamfgc mentioned this issue Jun 4, 2018
Merged
williamfgc added a commit to williamfgc/ADIOS2 that referenced this issue Jun 4, 2018
@williamfgc
Write side Put multiblock
0233167 
Related to ornladios#335
Refactored BP3 Serializer to allow multiblock
Added multiblock info data structure in Variable
DefineVariable pointer removed for type except in Python
APIs: numpy array or string in define variable.
Tests added

TO DO:
    read multiblock (separate branch)
williamfgc added a commit to williamfgc/ADIOS2 that referenced this issue Jun 25, 2018
@williamfgc
Added Multiblock and Multistep tests
4202640 
Satisfies enhancement ornladios#335
Solves bug ornladios#682 , bug ornladios#573, bug ornladios#675, bug ornladios#613
@williamfgc
Copy link
Contributor

Closing this as this is supported at user API level by bpfile in sync and deferred modes in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamfgc williamfgc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eisenhauer @pnorbert @guj @williamfgc