bpls: Avoid looking up variables and attributes we already have

ornladios · Jul 6, 2020 · e5ad0f5 · e5ad0f5
1 parent 7ebe887
commit e5ad0f5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/source/utils/bpls/bpls.cpp b/source/utils/bpls/bpls.cpp
@@ -907,15 +907,15 @@ int doList_vars(core::Engine *fp, core::IO *io)
     {
         for (const auto &vpair : variables)
         {
-            Entry e(true, vpair.second->m_Type);
+            Entry e(vpair.second->m_Type, vpair.second.get());
             entries.emplace(vpair.first, e);
         }
     }
     if (listattrs)
     {
         for (const auto &apair : attributes)
         {
-            Entry e(false, apair.second->m_Type);
+            Entry e(apair.second->m_Type, apair.second.get());
             entries.emplace(apair.first, e);
         }
     }
@@ -963,7 +963,7 @@ int doList_vars(core::Engine *fp, core::IO *io)
 #define declare_template_instantiation(T)                                      \
     else if (entry.typeName == helper::GetDataType<T>())                       \
     {                                                                          \
-        core::Attribute<T> *a = io->InquireAttribute<T>(name);                 \
+        core::Attribute<T> *a = static_cast<core::Attribute<T> *>(entry.attr); \
         retval = printAttributeValue(fp, io, a);                               \
     }
                     ADIOS2_FOREACH_ATTRIBUTE_STDTYPE_1ARG(
@@ -986,7 +986,7 @@ int doList_vars(core::Engine *fp, core::IO *io)
 #define declare_template_instantiation(T)                                      \
     else if (entry.typeName == helper::GetDataType<T>())                       \
     {                                                                          \
-        core::Variable<T> *v = io->InquireVariable<T>(name);                   \
+        core::Variable<T> *v = static_cast<core::Variable<T> *>(entry.var);    \
         retval = printVariableInfo(fp, io, v);                                 \
     }
                 ADIOS2_FOREACH_STDTYPE_1ARG(declare_template_instantiation)

diff --git a/source/utils/bpls/bpls.h b/source/utils/bpls/bpls.h
@@ -37,9 +37,21 @@ namespace utils
 
 struct Entry
 {
-    bool isVar;
     DataType typeName;
-    Entry(bool b, DataType type) : isVar(b), typeName(type) {}
+    bool isVar;
+    union
+    {
+        core::VariableBase *var;
+        core::AttributeBase *attr;
+    };
+    Entry(DataType type, core::VariableBase *v)
+    : typeName(type), isVar(true), var(v)
+    {
+    }
+    Entry(DataType type, core::AttributeBase *a)
+    : typeName(type), isVar(false), attr(a)
+    {
+    }
 };
 
 // how to print one data item of an array