-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mpiwrap: get rid of unused m_RankMPI, m_SizeMPI in Transport
They are unused, since all transports are serial. If someone were to add a MPI-I/O Transport in the future, it might make sense to save rank/size within that new derived class, but it's not really a generically needed thing.
- Loading branch information
Showing
2 changed files
with
0 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b8b4d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germasch Please don't get rid of this. While not actively developed, shared memory SystemV transports use the rank/size to create a unique key. Because a feature is not used today in production, it doesn't mean it wasn't thought as part of the class abstraction. Thanks.