azurite preset based on the localstack preset #837

aeolus3000 · 2023-03-11T19:15:55Z

Proposing a azurite preset.

I would still need help with the following steps:
Generate [client SDK code]

Azurrite offers other stuff like table store but I didn't need that yet. Does anyone feel energetic to add that here?

orlangure · 2023-03-11T21:30:07Z

This is fantastic, thank you for the contribution!

I wasn't aware of azurite, it looks very useful, I hope it gets extended with more azure services in the future 😼

I wasn't able to properly review the code, but I have 2 small comments so far:

No need to generate the SDK, I stopped supporting it since it consumes way to much energy for very little to no value. All your gnomock server and swagger changes are enough.
Please add the new preset tests (preset and server tests) to github actions and circleci configuration files, otherwise these tests won't run automatically. If you don't have time to do that, let me know, and I'll add these myself.

I will find time to go over the code and provide more feedback if needed. So far it looks great and very similar to localstack, which is very nice.

aeolus3000 · 2023-03-12T08:59:14Z

Thanks for having a look into it and the missing files!

They are added now.

aeolus3000 · 2023-03-13T08:21:29Z

I think that the changes in CONTRIBUTING.md can be reverted.

Correct, @orlangure ?

orlangure

This is so cool, thank you!

A couple of small comments I'd be happy you address, and this is good to go.

Also, can you please rebase from master? There was another preset merged just now, and there are a few conflicts because of it. Thanks!

orlangure · 2023-03-17T23:28:02Z

CONTRIBUTING.md

+1. Generate [client SDK
+   code](https://github.com/orlangure/gnomock#using-gnomock-server). Gnomock
+   uses OpenAPI to generate client code from swagger specification.
+
+1. Add client SDK tests for the new preset. These tests go into
+   [`sdktest`](https://github.com/orlangure/gnomock/tree/master/sdktest)
+   package. They allow to make sure that client code in languages other than Go
+   does not break after each update.
+


These are no longer required, I removed these points a few days ago😼

orlangure · 2023-03-17T23:34:36Z

preset/azurite/README.md

@@ -0,0 +1,73 @@
+# Gnomock Blobstorage


I'm not sure what's the best name for this one.

In localstack, we call it "localstack", and there are internal services that it exposes. Even though the users look for s3 or sqs, the preset is still named localstack.

I think we should keep this convention, and since you already named the preset azurite, I believe the readme should also use the term "azurite".

The Example (this is great by the way!) on the other hand should keep the name "blog storage" in it, because it demonstrates a subset of azurite capabilities.

Do you agree?

With the test i'm fine.

Or do you refer to the internal/gnomockd/azurite_test.go?
In this one I would leave it as "TestAzurite" because it is the same in localstack (it only tests s3 but is named localstack)

Can you please check once more?

preset/azurite/README.md

…omock into dev/preset_azurite

orlangure

Thank you for your great work and sorry for the delay in getting this merged.
A few more minor comments for you to address if that's ok.
Also, it appears that the tests are failing, and there are some lint warnings. Will you have time to resolve these?

orlangure · 2023-04-05T13:05:53Z

go.mod

+	k8s.io/api v0.26.1
+	k8s.io/apimachinery v0.26.1
+	k8s.io/client-go v0.26.1


Some of the dependencies were accidentally rolled back, can you revert please?

preset/azurite/preset_test.go

go.mod

codecov-commenter · 2023-04-12T11:53:11Z

Codecov Report

Patch coverage: 84.81% and project coverage change: -0.37 ⚠️

Comparison is base (97f7ed9) 85.87% compared to head (a0ee700) 85.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   85.87%   85.50%   -0.37%     
==========================================
  Files          50       55       +5     
  Lines        2350     2567     +217     
==========================================
+ Hits         2018     2195     +177     
- Misses        173      193      +20     
- Partials      159      179      +20

Impacted Files	Coverage Δ
preset/azurite/options_blobstorage.go	`70.14% <70.14%> (ø)`
preset/vault/preset.go	`77.41% <77.41%> (ø)`
preset/k3s/preset.go	`80.39% <94.11%> (-0.95%)`	⬇️
preset/azurite/options.go	`100.00% <100.00%> (ø)`
preset/azurite/preset.go	`100.00% <100.00%> (ø)`
preset/cassandra/preset.go	`93.10% <100.00%> (ø)`
preset/cockroachdb/preset.go	`81.53% <100.00%> (ø)`
preset/elastic/preset.go	`68.70% <100.00%> (+0.24%)`	⬆️
preset/k3s/options.go	`100.00% <100.00%> (ø)`
preset/mariadb/preset.go	`88.57% <100.00%> (ø)`
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

aeolus3000 · 2023-06-03T11:29:20Z

@orlangure can you please cross check again?
I don't understand why the test coverage is so low. when I run the tests locally I have more than 85 % coverage. Am I missing something?

orlangure · 2023-06-09T20:08:36Z

Hey @aeolus3000, your tests and their coverage are great, the build just didn't start automatically because you still don't have any merged contributions (not for long 😼). Now that I manually approved those, codecov no longer complains, but you do have a couple of minor lint warnings to resolve. After that this PR will be merged, and I'll prepare a new release so everybody can enjoy your work. Thank you!

aeolus3000 · 2023-07-10T07:47:15Z

@orlangure I have found some time on the weekend to work on the lint checks. Can you please approve the workflows?

internal/gnomockd/azurite_test.go

preset/azurite/preset_test.go

orlangure

Amazing work, thank you for doing this!

orlangure · 2023-07-15T13:10:21Z

Would you mind resolving merge conflicts so I can merge this?

aeolus3000 · 2023-07-21T09:35:27Z

Hey @orlangure

I can't find a merge conflict. Can you point that out to me please?

orlangure · 2023-07-29T06:48:35Z

Hey @aeolus3000,
I wasn't able to merge this from GitHub UI, but mobile version didn't show any warnings about conflicts in code. Sorry for the confusion, fully merged now. This is a great addition, thank you for your work and patience 😼

aeolus3000 added 2 commits March 11, 2023 20:14

azurite preset based on the localstack preset

079b8fc

fix container name

faeb3d7

orlangure assigned aeolus3000 Mar 11, 2023

aeolus3000 added 2 commits March 12, 2023 09:53

add git actions and circle ci

4e346be

add missing line break

bc882e6

orlangure reviewed Mar 17, 2023

View reviewed changes

Merge branch 'master' into dev/preset_azurite

8fcd9a3

aeolus3000 commented Mar 23, 2023

View reviewed changes

preset/azurite/README.md Outdated Show resolved Hide resolved

aeolus3000 and others added 3 commits March 23, 2023 15:13

Update preset/azurite/README.md

3c4fe64

revert contributing

30f5b20

Merge branch 'dev/preset_azurite' of https://github.com/aeolus3000/gn…

75dee42

…omock into dev/preset_azurite

orlangure reviewed Apr 5, 2023

View reviewed changes

aeolus3000 commented Apr 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

aeolus3000 commented Apr 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

aeolus3000 commented Apr 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

aeolus3000 commented Apr 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Apply suggestions from code review

8f540d3

aeolus3000 and others added 5 commits June 3, 2023 12:20

use require instead

36cec27

use context background

ed2a1eb

Merge branch 'master' into dev/preset_azurite

fdde017

sort order in go mod

cfc5cdd

prefix filename

4e742f2

aeolus3000 added 2 commits July 9, 2023 09:53

fix lint checks

4f15c2a

change assert -> require

3e45a00

aeolus3000 commented Jul 13, 2023

View reviewed changes

internal/gnomockd/azurite_test.go Show resolved Hide resolved

aeolus3000 commented Jul 13, 2023

View reviewed changes

preset/azurite/preset_test.go Show resolved Hide resolved

aeolus3000 and others added 2 commits July 13, 2023 10:15

Apply suggestions from code review

173feee

change assert -> require

2ec5674

aeolus3000 force-pushed the dev/preset_azurite branch from f67019a to 2ec5674 Compare July 13, 2023 12:50

gofmt -s -w preset_test.go

a0ee700

orlangure approved these changes Jul 15, 2023

View reviewed changes

orlangure merged commit 5ed38a4 into orlangure:master Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azurite preset based on the localstack preset #837

azurite preset based on the localstack preset #837

aeolus3000 commented Mar 11, 2023 •

edited

Loading

orlangure commented Mar 11, 2023

aeolus3000 commented Mar 12, 2023

aeolus3000 commented Mar 13, 2023

orlangure left a comment

orlangure Mar 17, 2023

orlangure Mar 17, 2023

aeolus3000 Mar 23, 2023

aeolus3000 Mar 23, 2023

aeolus3000 Apr 5, 2023

orlangure left a comment

orlangure Apr 5, 2023

codecov-commenter commented Apr 12, 2023 •

edited

Loading

aeolus3000 commented Jun 3, 2023

orlangure commented Jun 9, 2023

aeolus3000 commented Jul 10, 2023

orlangure left a comment

orlangure commented Jul 15, 2023

aeolus3000 commented Jul 21, 2023

orlangure commented Jul 29, 2023

azurite preset based on the localstack preset #837

azurite preset based on the localstack preset #837

Conversation

aeolus3000 commented Mar 11, 2023 • edited Loading

orlangure commented Mar 11, 2023

aeolus3000 commented Mar 12, 2023

aeolus3000 commented Mar 13, 2023

orlangure left a comment

Choose a reason for hiding this comment

orlangure Mar 17, 2023

Choose a reason for hiding this comment

orlangure Mar 17, 2023

Choose a reason for hiding this comment

aeolus3000 Mar 23, 2023

Choose a reason for hiding this comment

aeolus3000 Mar 23, 2023

Choose a reason for hiding this comment

aeolus3000 Apr 5, 2023

Choose a reason for hiding this comment

orlangure left a comment

Choose a reason for hiding this comment

orlangure Apr 5, 2023

Choose a reason for hiding this comment

codecov-commenter commented Apr 12, 2023 • edited Loading

Codecov Report

aeolus3000 commented Jun 3, 2023

orlangure commented Jun 9, 2023

aeolus3000 commented Jul 10, 2023

orlangure left a comment

Choose a reason for hiding this comment

orlangure commented Jul 15, 2023

aeolus3000 commented Jul 21, 2023

orlangure commented Jul 29, 2023

aeolus3000 commented Mar 11, 2023 •

edited

Loading

codecov-commenter commented Apr 12, 2023 •

edited

Loading