Review in the form of pull request #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
original-brownbear
pushed a commit
that referenced
this pull request
Oct 31, 2024
…sion (#1…" (elastic#115827) This reverts commit 32dee6a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic#78075
👋 @original-brownbear.
re: 5adcf14: the set declaration and initialization looked a bit funky to me, this is my attempt to make that a little more readable.
re: dfebb2a:
Strings.tokenizeToStringArraydoes a healthy number of allocations, but we can shortcut it in the null/empty String case -- I was originally tempted to add a separate early return fromallocationAllowedthat checkedStrings.hasLength(tierSetting)directly, but I thought this would capture more or less the same shortcut while keeping the code pretty clear.re: ea03188: If we're allocating a
HashSet, we might as well go all the way and usecontainsAll-- what do you think?This is very much "hmmmm, what do you think about this?" -- we can take all, some, or none of these commits.