Remove Overly Strict Assertion in TransportShardBulkAction

* In elastic#39793 this assertion was added under the assumption that no exceptions would be thrown in this method, which turned out not to be correct and at the very least `org.elasticsearch.index.shard.IndexShardClosedException` can be thrown by `org.elasticsearch.index.shard.IndexShard.sync` * Closes elastic#40933
original-brownbear · Apr 8, 2019 · 7c3e3cc · 7c3e3cc
1 parent 675bf3c
commit 7c3e3cc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java
@@ -170,7 +170,6 @@ protected void doRun() {
 
             @Override
             public void onFailure(Exception e) {
-                assert false : "All exceptions should be handled by #executeBulkItemRequest";
                 onRejection(e);
             }
 

diff --git a/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/integration/AnnotationIndexIT.java b/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/integration/AnnotationIndexIT.java
@@ -51,7 +51,6 @@ public void testNotCreatedWhenNoOtherMlIndices() {
         }
     }
 
-    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/40933")
     public void testCreatedWhenAfterOtherMlIndex() throws Exception {
 
         Auditor auditor = new Auditor(client(), "node_1");
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,7 +51,6 @@ public void testNotCreatedWhenNoOtherMlIndices() { @@
             }
         }
-        @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/40933")
         public void testCreatedWhenAfterOtherMlIndex() throws Exception {
             Auditor auditor = new Auditor(client(), "node_1");
@@ Expand Down @@