Fix type GulpESLintOptions for ESLint v9 compatibility

origin-1 · Jul 7, 2024 · 674c170 · 674c170
1 parent f49d67a
commit 674c170
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/gulp-eslint-new.d.ts b/lib/gulp-eslint-new.d.ts
@@ -113,8 +113,9 @@ declare namespace gulpESLintNew
     }
 
     type GulpESLintOptions =
-    (GulpESLintrcOptions & { configType?: 'eslintrc' | null | undefined; }) |
-    (GulpFlatESLintOptions & { configType: 'flat'; });
+    | ((GulpESLintrcOptions | GulpFlatESLintOptions) & { configType?: null | undefined; })
+    | (GulpESLintrcOptions & { configType: 'eslintrc'; })
+    | (GulpFlatESLintOptions & { configType: 'flat'; });
 
     type GulpESLintResult = eslint.LintResult;
 

diff --git a/test/ts-defs-test.ts b/test/ts-defs-test.ts
@@ -26,6 +26,25 @@ gulpESLintNew
     },
 );
 
+{
+    let configType!: undefined | null;
+    gulpESLintNew
+    ({ configType, ignorePatterns: undefined, ruleFilter: undefined, stats: undefined });
+}
+
+{
+    let configType!: undefined | null;
+    gulpESLintNew
+    (
+        {
+            configType,
+            reportUnusedDisableDirectives:  undefined,
+            resolvePluginsRelativeTo:       undefined,
+            rulePaths:                      undefined,
+        },
+    );
+}
+
 gulpESLintNew
 (
     {