Tasks, Concurrency, and Cancellation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial mitigation of #174 until Tasks are formalised. The common problems of cancelling tasks are solved by this, but there's no way of knowing if other edge cases exist without formalising. The final solution will probably still involve linking tasks somehow so propagation works correctly, anyway.
robotlolita
added
m:Needs Tests
e:Unknown
in progress
c:Concurrency
k:Fix
a:Base
labels
ghost
assigned
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are still experimental and they're developed in a fairly adhoc manner. This results in a lot of edge cases that are hard to cover under concurrent execution (races are always a pain), and makes it harder for people to reason about their code. #174 and #153 are examples of that.
The current PR includes an initial mitigation of #174 until Tasks are formalised. The common problems of cancelling tasks are solved by this, but there's no way of knowing if other edge cases exist without formalising.
You can try out these changes by installing version
2.2.0-alpha1, or just grab the@nextbranch: