Fix Success value in notEmpty validation example
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, the newline at the end is fine. But since the documentation is auto-generated, could you edit this Markdown file instead? https://github.com/origamitower/folktale/blob/master/annotations/source/en/validation/index.md |
|
@robotlolita Should both files be edited in the final PR? |
|
No, just the Markdown one. |
I was reading through the `Validation` documentation and noticed this little typo. I'm correct in assuming that the validators should return their `value` property in a `Success`, not the `field`, right?
robotlolita
approved these changes
Sep 6, 2017
|
Thanksies :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the
Validationdocumentation and noticed this little typo(?). I'm correct in assuming that the validators should return theirvalueproperty in aSuccess, not thefield, right?Sorry about the extraMaking the change in the markdown file made this comment moot.\nat EOF. I made this patch with the Github editor and it looks like it just tacked that on. I can kill it if y'all prefer.