Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect example of Task.willMatchWith in the migrating docs #159

Closed
robotlolita opened this issue Oct 11, 2017 · 0 comments · Fixed by #160
Closed

Incorrect example of Task.willMatchWith in the migrating docs #159

robotlolita opened this issue Oct 11, 2017 · 0 comments · Fixed by #160
Assignees
@robotlolita
Labels
a:Documentation k:Error

Comments

@robotlolita
Copy link
Member

robotlolita commented Oct 11, 2017 •
edited
Loading

The examples for migrating from Task.fold/cata to Task.willMatchWith in http://folktale.origamitower.com/docs/v2.0.0/migrating/from-data.task/#taskfold-and-taskcata are incorrect because Task.willMatchWith expects a new task to be returned from every function.

The docs also don't show an equivalent piece of code for the usage of Task.fork(onError, onSuccess), which is confusing for people who used it before (#158).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robotlolita robotlolita

Labels
a:Documentation k:Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes migration docs for Task origamitower/folktale
1 participant
@robotlolita