Skip to content

Commit

Permalink
(!!) Removes support for Node 5.x due to v8 bugs (#47)
Browse files Browse the repository at this point in the history
v8 4.6.85.x (Node 5.x) has a bug in the optimiser where an invocation of Object.defineProperty passing the result of Object.getOwnPropertyDescriptor in Core.ADT's `extend` function ends up evaluating the latter to undefined in the absence of other side-effects.

See #47 for more details.
  • Loading branch information
robotlolita committed Oct 12, 2016
1 parent 4ddd612 commit bf2ec8a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
language: node_js
node_js:
- "4"
- "5"
- "6"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Folktale can be installed through [npm][]:

## Supported platforms

- Node 4+
- Node 4.x, Node 6+ ([**Node 5.x is not supported**](https://github.com/origamitower/folktale/issues/47))

**Browsers**:
- Chrome 23+
Expand Down
4 changes: 1 addition & 3 deletions test/specs-src/core.adt.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
//
//----------------------------------------------------------------------

const { property, forall} = require('jsverify');
const { property } = require('jsverify');
const {data, setoid, show, serialize} = require('folktale/core/adt')

describe('Core.ADT', () => {
Expand Down Expand Up @@ -130,12 +130,10 @@ describe('Core.ADT', () => {
// NOTE: this fails randomly in Node 5's v8. Seems to be a v8
// optimisation bug, although I haven't had the time to analyse
// it yet.
/*
property('Gets a tag with the same name as the constructor', 'string', (a) => {
const adt = data('', { [a](){ return {} }});
return adt[a]()[data.tagSymbol] === a;
});
*/

property('Gets a hasInstance method that only looks at type/tag', 'string', (a) => {
const b = a + '2';
Expand Down

0 comments on commit bf2ec8a

Please sign in to comment.