Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issues #8285 and #8284 #8299

Closed
wants to merge 4 commits into from
Closed

Fix for Issues #8285 and #8284 #8299

wants to merge 4 commits into from

Conversation

markodjurovic
Copy link
Contributor

Please pay extra attention to changes in OStringParser, because this tokenizer is used on few places

@andrii0lomakin
Copy link
Member

andrii0lomakin commented May 31, 2018

@markodjurovic Can we instead of fixing of StringParser apply some local fix? You see string parse is like "treatment from all diseases" so it is risky to change it and does not have side effects.

@hrstoyanov
Copy link

Thanks, when is 3.0.2 going to be released in the Maven repo?

@markodjurovic
Copy link
Contributor Author

@Laa
I can implement case specific fix. I will revert changes in StringParser for now, and later we can discuss about StringParser fix (I think it is valid fix, but let double check it).

@markodjurovic
Copy link
Contributor Author

OK I will close this PR and create new one

@markodjurovic markodjurovic deleted the issue8285 branch June 1, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants