Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 89, AES and DES encryption at rest #4018

Merged
merged 3 commits into from
Aug 11, 2015

Conversation

giastfader
Copy link
Contributor

This PR is related to #89
Here are two new cluster compression methods that use AES and DES to encrypt data.
Keys have to be declared into the configuration file, or in any other way supported by OrientDB (command line, direct set on OGlobalConfiguration enumerator).
There is of course room for improvements, consider this as a first WORKING implementation.

usage:

create class aes
alter cluster aes compression aes-encrypted

create class des
 alter cluster des compression des-encrypted

@lvca lvca self-assigned this Apr 28, 2015
@lvca lvca added this to the 2.2 milestone Apr 30, 2015
@lvca
Copy link
Member

lvca commented Apr 30, 2015

We're in RC phase, I'll merge this as soon as we start the 2.2-SNAPSHOT.

@lvca
Copy link
Member

lvca commented Aug 6, 2015

Hey @giastfader I was merging this in develop, but unfortunately you didn't sign the clahub agreement (for the Apache2 license). Please could you do that? Thanks in advance.

@lvca
Copy link
Member

lvca commented Aug 9, 2015

Waiting for you to electronic signing the CLA, I saw you use 2 new global settings:

STORAGE_ENCRYPTION_DES_KEY("encryption.des_key",
  "The simmetric key to use to encrypt/descript data at rest using the DES alghorithm, stored in BASE64. The key must be 64 bits long. Default is \"T1JJRU5UREI=\" (ORIENTDB).",String.class,"T1JJRU5UREI="),
STORAGE_ENCRYPTION_AES_KEY("encryption.aes_key",
  "The simmetric key to use to encrypt/descript data at rest using the AES alghorithm, stored in BASE64. The key must be 128 or 256 bits. Default is \"T1JJRU5UREJfSVNfQ09PTA==\" (ORIENTDB_IS_COOL).",String.class,"T1JJRU5UREJfSVNfQ09PTA=="),

I think it would be much better don't setting any password by default and check if password is null, an exception is raised. In this way the user can't do mistakes. WDYT?

@giastfader
Copy link
Contributor Author

Yes, I agree, if you want to force the admin to explicitly set a key.

@lvca
Copy link
Member

lvca commented Aug 11, 2015

Cool, I'm merging it right now

lvca added a commit that referenced this pull request Aug 11, 2015
Issue 89, AES and DES encryption at rest
@lvca lvca merged commit 3797a3e into orientechnologies:develop Aug 11, 2015
@lvca
Copy link
Member

lvca commented Aug 11, 2015

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants