Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Docker health check #28

Closed
robfrank opened this issue Feb 23, 2017 · 2 comments
Closed

Implement Docker health check #28

robfrank opened this issue Feb 23, 2017 · 2 comments
Assignees
@robfrank

Comments

@robfrank
Copy link

Reference docs:

https://docs.docker.com/engine/reference/builder/#healthcheck
@robfrank robfrank self-assigned this Feb 23, 2017
robfrank added a commit that referenced this issue Feb 23, 2017
@robfrank
adds healtcheck command
d3ef3a8 
refs #28
@mapcloud mapcloud mentioned this issue Mar 7, 2017
Merged
@stuartpb
Copy link

It looks like this was added and then... removed? Any insights as to why?

I'm currently looking at a patch to add HEALTHCHECK to the RethinkDB Dockerfiles, and I'm trying to understand how other official images have done it.

@lvca lvca reopened this Aug 31, 2017
@robfrank
Copy link
Author

You're right, was added and then removed. The docker team asked me to remove during the pr:

docker-library/official-images#2831

Pointing to this comment:

docker-library/cassandra#76 (comment)

So, even it seems a good idea, the docker team doesn't think it is: I don't think you will find an official image with health-check defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robfrank robfrank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lvca @robfrank @stuartpb