Updating any percentage/fraction cookies in parent of TODO/DONE items #545
+166
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'll need to look closer to refresh my memory, but I believe you are following the existing practices by putting this in data.DataRepository. I'm not really experienced enough to make judgments on this, but I think it's a bit of a "god class". It has a huge number of responsibilities and there is a big "split this up" TODO at the top. So I'm hoping someone will come along and suggest some refactoring. |
amberin
requested review from
alensiljak,
stefan2904,
colonelpanic8,
alexanderkunz,
amberin,
cbkerr and
philipp-reinhardt
amberin
approved these changes
Mar 10, 2025
alensiljak
approved these changes
Mar 10, 2025
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address issue #525; apologies for applying business logic in the repository layer but I couldn't find any other spots to pull this off which wouldn't have required a bunch of repetitive changes (such as across the UseCases). I'm certainly open to suggestion on reworking if this is in violation of standards/practices.