somafmservice.cpp basic question

[peddy22]

I want to prevent this file from loading the mp3 streams and just keep the aac streams. Should be easily done with something like this around line 112

      QString format = obj_playlist["format"].toString();
      if (format != "mp3") continue;

however the current code has a confusing Not Equal To statement at line 113

(113) if (quality != "highest") continue;
              channel.source = source_;
              channel.name = name;
              channel.url.setUrl(obj_playlist["url"].toString());
              channel.thumbnail_url.setUrl(image);

My question is, why is this a Not Equal To instead of an Equal To?

Thanks!

file linked here

[peddy22]

Debian patch file

Description: <short summary of the patch>
 TODO: Put a short summary on the line above and replace this paragraph
 with a longer explanation of this change. Complete the meta-information
 with other relevant fields (see below for details). To make it easier, the
 information below has been extracted from the changelog. Adjust it or drop
 it.
 .
 strawberry (1.0.18-1) unstable; urgency=medium
 .
   * New upstream release
Author: Peter Blackman <[email protected]>

---
The information above should follow the Patch Tagging Guidelines, please
checkout https://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: (upstream|backport|vendor|other), (<patch-url>|commit:<commit-id>)
Bug: <upstream-bugtracker-url>
Bug-Debian: https://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: (no|not-needed|<patch-forwarded-url>)
Applied-Upstream: <version>, (<commit-url>|commit:<commid-id>)
Reviewed-By: <name and email of someone who approved/reviewed the patch>
Last-Update: 2024-04-10

--- strawberry-1.0.18.orig/src/radios/somafmservice.cpp
+++ strawberry-1.0.18/src/radios/somafmservice.cpp
@@ -110,14 +110,14 @@ void SomaFMService::GetChannelsReply(QNe
       }
       RadioChannel channel;
       QString quality = obj_playlist["quality"].toString();
-      if (quality != "highest") continue;
+      QString format = obj_playlist["format"].toString();
+
+      if ((quality != "highest") || (format != "aac")) continue;
       channel.source = source_;
       channel.name = name;
       channel.url.setUrl(obj_playlist["url"].toString());
       channel.thumbnail_url.setUrl(image);
-      if (obj_playlist.contains("format")) {
-        channel.name.append(" " + obj_playlist["format"].toString().toUpper());
-      }
+
       channels << channel;
     }
   }

[peddy22]

The patch recently stopped working on the latest github version - can anyone help me out?

[jonaski]

You need to use QStringLiteral, like this.: QStringLiteral("aac")

[peddy22]

Ah there’s no point in me running the GitHub release until my system is qt6, it’s very ugly otherwise. Thanks for your reply Arno

…

On Mon, 15 Apr 2024 at 2:09 AM, Jonas Kvinge ***@***.***> wrote: You need to use QStringLiteral, like this.: QStringLiteral("aac") — Reply to this email directly, view it on GitHub <#1419 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOBXU3XWOIJYF7LWOSFSQEDY5KE2DAVCNFSM6AAAAABF6QMPIKVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TCMBZGU3TS> . You are receiving this because you modified the open/close state.Message ID: <strawberrymusicplayer/strawberry/repo-discussions/1419/comments/9109579@ github.com>