Pulsar Edit
Replies: 16 comments 41 replies
-
|
I do just want to add. Trying to get these listed on the MacOS App Store, and the Windows Store could be extremely helpful to avoid signing at all. Since once on those stores it's already trusted, and could negate the issue altogether |
Beta Was this translation helpful? Give feedback.
-
|
Actually, it's the opposite - we can ONLY list on these stores if we sign them... |
Beta Was this translation helpful? Give feedback.
-
Well that's just lame. Guess things had changed since last I checked our read it wrong. Thanks for pointing out the correction |
Beta Was this translation helpful? Give feedback.
-
|
Hmmmmmmm, I'm wondering if macOS is viable now, since I believe there is no extra cost than the $99/yr to get it listed on the macOS app store? |
Beta Was this translation helpful? Give feedback.
-
|
@meadowsys I'd have no issue with pursuing it at all. As long as an Electron app can be listed properly. I'd think the biggest concern would be file system access. Since I know the Windows store likes to be extra secure about that sort of thing, but am not to sure how it's handled on Mac |
Beta Was this translation helpful? Give feedback.
-
|
On macOS there is a permission you can give to an app to get full disk access. I wonder if we are able / should request it from Pulsar automatically or if we should just instruct people to add the permission manually |
Beta Was this translation helpful? Give feedback.
-
|
I would also like to throw the hat into the ring for Windows msi. Electron-builder can already make one, and it allows for a scriptable install/quiet install |
Beta Was this translation helpful? Give feedback.
-
|
I was going to add it as a target on my own branch, and then realized that I would need a pulsar-edit/pulsar branch to actually get Cirrus to build it lol |
Beta Was this translation helpful? Give feedback.
-
|
You can still run it manually, if it builds locally then there shouldn't be any reason why Cirrus can't build it. |
Beta Was this translation helpful? Give feedback.
-
|
I'd have to set up a dev instance on a Windows box, which is doable - but not done yet But good point, I forget it only runs the |
Beta Was this translation helpful? Give feedback.
-
|
@Spiker985 if needed I could submit a PR with any changes, do you have a repo I can look at for the implementation? Or is just like added the other build target like you did previously? |
Beta Was this translation helpful? Give feedback.
-
|
So quick update, as I tried to get Cirrus to build an MSI over on pulsar#279. But it seems MSI's won't work with our version naming. Essentially our build number, as it currently uses the date, is a higher value than MSI's will accept, which the maximum number you can specify as an MSI build number (according to Cirrus Error Logs) is 65536. Which we easily go over that. So this may mean we have to have custom build numbers for an MSI to be made, or otherwise we could find a way to resolve that issue. |
Beta Was this translation helpful? Give feedback.
-
|
I already tried building pulsar on alpine, |
Beta Was this translation helpful? Give feedback.
-
|
Well this is more about what should we support in terms of packages and repos. It should be buildable on nearly everything so if you need help feel free to ask in the #build channel on discord or open a new thread. |
Beta Was this translation helpful? Give feedback.
-
|
macOS PKG installers are rare. I have only seen PKG installers used for things like audio plugins, drivers, and this audio loopback thingie I installed. I usually see DMG installers only (as in, it is the only option provided). Sometimes I see zip files being used (maybe because they are easier to package? but for us DMGs are automated anyways). I also get the impression that DMG files can compress the application bundle down a lot more than ZIP files can. TL;DR I do not think a PKG installer is needed for macOS. Honestly, offering only a DMG should be enough? |
Beta Was this translation helpful? Give feedback.
-
|
I agree personally, just covering all bases in case somebody asks. |
Beta Was this translation helpful? Give feedback.
-
|
Originally, pkg was added by me to allow universal DMG packages (the doc I saw mentioned combining two pkg files). Unfortunately, Cirrus does not have sufficient disk space to build both DMG and pkg for both platforms, and that also made the build slow and brittle. So, let's drop pkg indeed 👍 |
Beta Was this translation helpful? Give feedback.
-
|
I'm a big Flatpak advocate, so I'd vote for that. |
Beta Was this translation helpful? Give feedback.
-
|
Definitely need flatpak, but probably support copr as it also supports opensuse and a few other distros if configured right. I was trying to figure this out to add to the existing build config but the documentation for it confused the heck out of me.... |
Beta Was this translation helpful? Give feedback.
-
|
In my opinion Flatpak is the only thing the team should ship on its own and it covers the most number of Linux distributions. For other formats, the distributions will do them if they want like the AUR package. |
Beta Was this translation helpful? Give feedback.
-
|
With Flathub gearing up to support markers for official packages, I think it's a good idea to get on that boat early. |
Beta Was this translation helpful? Give feedback.
-
This, flatpak alone would help us tremendously and maybe snap down the line. That way we're in repos people already have on their systems. I'm still going to eventually look at copr as well but will have to figure things out. |
Beta Was this translation helpful? Give feedback.
-
|
To answer the open post, the AUR is made by @jonian It's not official because on Arch only the packages on upstream are "official". On AUR they're all user made, but it works. |
Beta Was this translation helpful? Give feedback.
-
|
I think "official" in this context refers to "Pulsar-Edit" supported rather than community member. i.e. if we wanted we could have an "official" Pulsar AUR entry with associated pkgbuild within the pulsar-edit repos. |
Beta Was this translation helpful? Give feedback.
-
I think it will become outdated because there's no one who update it. The only thing official made here about linux should be the flatpak build in my opinion. |
Beta Was this translation helpful? Give feedback.
-
|
FlatPak & Snap must be supported with regular updates. Distro specific support is also welcome. Can we just stop caring about Windows and Mac users? |
Beta Was this translation helpful? Give feedback.
-
I would ban you from here only for saying this. Respect other people choice. The discussion is over for me. |
Beta Was this translation helpful? Give feedback.
-
Ban me. I have zero respect for Microsoft users and admirers. No question of respecting idiots. Go ahead. Ban me. |
Beta Was this translation helpful? Give feedback.
-
Your thinking here is really rediculous. I use Linux at home but what about work? I don't have any choice other than to use Windows and why would I not want to use the editor I'm spending time trying to improve? Not every Windows user is an "admirer". |
Beta Was this translation helpful? Give feedback.
-
That's my point. Anyway, I think it's stretching more than necessary. So, let's leave it here.
Great initiative. Great project. Keep it up. Let's hope that Pulsar takes all of us far ahead. I am happy to meet you guys. Have a nice day! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the support, ultimately we just want to support the application and users so unfortunately that does mean making sacrifices in terms of ideals sometimes (for example, do I support GitHub? No, but the benefits it gives to the application outweighs the idealistic negatives for the time being). |
Beta Was this translation helpful? Give feedback.
-
|
As a high school teacher I really like the .deb support as I can install this excellent, excellent editor on my Chromebook! Thank you so much for putting energy into this project! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a ton for your kind words. Super happy to hear this provides some value to you! |
Beta Was this translation helpful? Give feedback.
-
|
Discovered this discussion late, but I've been working on Nix, via the nixpkgs |
Beta Was this translation helpful? Give feedback.
-
|
Awesome, not sure how to link to the package itself on the site other than via a query but I'll add it to the list - https://search.nixos.org/packages?channel=unstable&show=pulsar |
Beta Was this translation helpful? Give feedback.
-
|
Either use the query, or the actual recipe: But both are good :) (there is no standard for this, so both are good. Even then with the query, the button "show source" links back to the nix recipe) |
Beta Was this translation helpful? Give feedback.
-
|
Definitely want a link to the site as that is far more what end users would expect but it seems really weird that each package doesn't actually have a URL on the website for purpose of linking it to other people. |
Beta Was this translation helpful? Give feedback.
-
|
I wish there was something like this, but alas the Nix documentation is still lacking... |
Beta Was this translation helpful? Give feedback.
-
How to update the package(This guide is meant for people who want to also to contribute to keeping this package up to date and become a maintainer) BasicsYou can probably just do it through the usual contributing guide from Nixpkgs. If nothing major changes in how the package is published, you could probably just run the After that, it's the usual If it's good, it's the usual PR on GitHub :) Some gotchasaarch64The derivation also supports aarch64. Cross-building is having issues so you could try it but I'm not assured it would work. I would advise instead to try to build from a free Oracle Ampere VM, or a raspberry Pi. I'm not sure if it's required to test if it builds on aarch64, but it's a nice move if you do Change in the release formatThe update script assumes that release have a special formats on GitHub:
If those file name changes, the update script will fail. In that case you will probably need to update the file name in the Nix file. (If you can, also update the updater script) Change in the buildThe Pulsar package is based on the prebuilt tarball. If it's format changes from version to version, the patches needed to make it work on Nix will break. Another sort of brittle part is the wrapper script. It assumes that the Pulsar bin is at |
Beta Was this translation helpful? Give feedback.
-
|
We've got a plus one for scoop |
Beta Was this translation helpful? Give feedback.
-
|
Wrote a Scoop JSON. It probably can get enhanced (like automated new version discovery), but at least that's a great first step :) {
"version": "1.103.0",
"license": "MIT",
"architecture": {
"64bit": {
"url": "https://github.com/pulsar-edit/pulsar/releases/download/v1.103.0/Windows.Pulsar.1.103.0.exe",
"hash": "sha256:40872f766c5d758add4cab9a4d8ace37f07dadd4ee5240ea81d7c096a169f0c2"
}
},
"pre_install": "Rename-Item \"$dir\\Windows.Pulsar.$version.exe\" \"pulsar.exe\"",
"bin": "pulsar.exe",
"homepage": "https://pulsar-edit.dev/",
"description": "A Community-led Hyper-Hackable Text Editor",
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/pulsar-edit/pulsar/releases/download/v$cleanVersion/Windows.Pulsar.$cleanVersion.exe"
}
}
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Hello, Do you plan to officially support snap? |
Beta Was this translation helpful? Give feedback.
-
|
There is no official standpoint on it yet but I would personally say yes we should (and why it is bolded in the post). |
Beta Was this translation helpful? Give feedback.
-
|
Great project! I wish you lots of success. |
Beta Was this translation helpful? Give feedback.
-
So this kind of relates to pulsar-edit/pulsar#62 but is also just a general talking point on it and useful as a reference point if people start requesting that we support x, y or z package/binary/OS.
This is a list of some of the more common ones and I'll happily edit this to account for any that I've missed. I am not saying that these all need to be supported, just giving options to the team and anyone who may want to create and maintain a community package.
I've tried to put this in some kind of order based on types and importance.
The standard ones I think are essential are bolded.
All OSs
Linux
Universal binaries
Universal repositories
Distro specific binaries
Distro specific repositories
apt)Other repos
macOS
Binaries
pkgSee this discussion comment ~vapor trail (@meadowsys)Repositories
Windows
Binaries
.exe portable- Used to but removed as too slowRepositories
BSD???
Beta Was this translation helpful? Give feedback.
All reactions