GitHub Community
New commit details page (public beta) feedback #139005
Replies: 442 comments 544 replies
-
|
My first reaction to the new page was: What is happening now!?! My second impression was: why is everything 50% bigger, did I Ctrl+Scroll to zoom by accident? And my third was: where are the diff count squares? Also I just found the first bug: when having text selected and trying to extend that selection with shift, that no longer works. Also I was just searching a bit for a commit message because since it is now completely grey, I kinda missed it. |
Beta Was this translation helpful? Give feedback.
-
|
how tofix, i don't know |
Beta Was this translation helpful? Give feedback.
-
|
Good |
Beta Was this translation helpful? Give feedback.
-
|
Need help with the receipt |
Beta Was this translation helpful? Give feedback.
-
|
cryptoflashG is a scammer |
Beta Was this translation helpful? Give feedback.
-
|
Hello will be fix to connect all tags? 9+? |
Beta Was this translation helpful? Give feedback.
-
|
I personally dislike the new page's design. |
Beta Was this translation helpful? Give feedback.
-
|
چه چیزروادغام وتقسیم می کنیدکه کنم بادوتافرمو ل. وحساب کتاب خودتون میدونیدچکارکنیدباکاربران |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
that's really |
Beta Was this translation helpful? Give feedback.
-
|
hi this reaaly? |
Beta Was this translation helpful? Give feedback.
-
|
I cant see now how my files have been changed by size, thats not good |
Beta Was this translation helpful? Give feedback.
-
|
Is there a known issue or limitation that prevents file size changes from being visible? |
Beta Was this translation helpful? Give feedback.
-
|
حل جميع المشاكل متعلقه بجوجل ادس |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Beta Was this translation helpful? Give feedback.
-
|
@generalmimon wrote:
I mostly work alone, and this form factor is good for comments that I wouldn't want in the code itself if they're too messy, but belong to specific lines of code and thus would not go well in the commit message. Think of them like sticky notes on a printout of the code, that I could take to a meeting with other developers, and move onto the whiteboard if helpful. |
Beta Was this translation helpful? Give feedback.
-
Please add this. I've just seen the new UI and had to disable it because reviewing a large file when all comments are hidden was a pain. In the end, I had to go through each one of them to check if I had missed any. |
Beta Was this translation helpful? Give feedback.
-
|
good feedback. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
good code |
Beta Was this translation helpful? Give feedback.
-
|
My feedback is, thank you for putting the green "beta" mark with a link to this post explaining. I like the new design, but when it happened, I was in the middle of writing comments on a commit and it was very confusing to me why the design changed. I thought for a little while that the project maintainer was collapsing my comments until I found the link to this page. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for this feedback! This new page will be fully rolled out (in beta) by today, but we have other beta features that will be shipping soon, and we'll make sure to test this flow to ensure nothing breaks (and the experience is not confusing). |
Beta Was this translation helpful? Give feedback.
-
|
That's odd, because my page says "Alpha". I would argue that its live, and there is no way to toggle the page back then you can't really call it a beta. |
Beta Was this translation helpful? Give feedback.
-
|
I appreciated the beta link to this discussion at first. Now that I've been receiving comment emails for months, I'm appreciating GitHub making such a poorly received change in the first place a lot less. |
Beta Was this translation helpful? Give feedback.
-
|
The problem (as mentioned by others), isn't the scaling, the scaling is actually the same as before. The issue is the If this is for accessibility purposes, then it should be it's own feature preview or option that the user can toggle. Another issue that's not mentioned yet is that commits with really long descriptions now have a "Show more" button instead of just showing the full description. If I'm clicking on a commit, I probably want to read the description. Please don't make me click multiple times. The text could also be made brighter and easier to read as it was before. See with this example commit: mpv-player/mpv@d2f3b66 |
Beta Was this translation helpful? Give feedback.
-
We rolled out a fix for this 🎉. See "Recent fixes and enhancements ✅" above. |
Beta Was this translation helpful? Give feedback.
-
We also just rolled out a new setting that lets you control line height (see description). |
Beta Was this translation helpful? Give feedback.
-
|
I dislike that the file name and path gets shortened despite there being plenty of horizontal space in the bar. And I can't even hover it to get the full path, I have to hover the "expand" button for the purpose of this screenshot. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. Agree --- there's no reason to truncate the file path when there's plenty of space to show it. I opened an issue. |
Beta Was this translation helpful? Give feedback.
-
|
A fix rolled out for this last night! 🎉 Take a look and let us know if you're still seeing a problem. |
Beta Was this translation helpful? Give feedback.
-
|
Honestly, I liked the old design better. I hope there will be an option to switch between them. |
Beta Was this translation helpful? Give feedback.
-
|
I personally agree with @R0rt1z2, I like that github now finally seems to fit the code view to the full width of the screen (which it previously did not do on 4K displays) but the function call navigation and file navigation sidebars are annoying. I understand the usage of the sidebar navigation but I wish that explicitly dismissing it would keep it hidden and not reopen it when I click, highlight, or navigate in the code. Much like @R0rt1z2, this is mostly personal preference, some of which I fixed with greasemonkey scripts but I still feel the behavior is incorrect. I also agree with the comment box width problem. For a long time, GitHub had used explicit pixel widths for many elements instead of using relative spacing and this made viewing on 4K or higher resolution displays quite annoying. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We're looking into it. |
Beta Was this translation helpful? Give feedback.
-
@R0rt1z2 - we rolled out a fix for indentation issues on some browsers. Can you see if it resolves your issue with viewing this commit? |
Beta Was this translation helpful? Give feedback.
-
@willsmythe It seems to be working fine now. I tried with that commit, and the indentation looks correct. I'm using Firefox on Windows.
|
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
... I can't right click to copy/paste the code? |
Beta Was this translation helpful? Give feedback.
-
Noticed this too; selection should (also) stay. |
Beta Was this translation helpful? Give feedback.
-
How about just not hijacking the native right-click behavior? |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
This public discutions can i commented too? |
Beta Was this translation helpful? Give feedback.
-
|
بنده روببخشیدعذرمیخوام ولی خداوکیلی ازی طرف ازتحتساب بازیهامون کم میشه ازی طرف اینجاتقسبم حذف میشه |
Beta Was this translation helpful? Give feedback.
-
|
The new design seems to struggle with tab indentation in files. For the sake of completeness I'll mention that the below screenshots are using 4-space tabs in my user settings but the effect in the new design is the same with the default of 8. Old: New: |
Beta Was this translation helpful? Give feedback.
-
|
seems like it's just "swallowing" the first tab, and even more because the first letter is cut off
|
Beta Was this translation helpful? Give feedback.
-
|
I saw just the new commit page for the first time today and it's not understandable to me how Github has not stopped the beta rollout when there's such an obvious bug. |
Beta Was this translation helpful? Give feedback.
-
|
What browser/OS are you all on, and do you have any plugins for GitHub installed? |
Beta Was this translation helpful? Give feedback.
-
|
Firefox on Linux (X11). No plugins or CSS modifications for GH. |
Beta Was this translation helpful? Give feedback.
-
|
The default-collapsed commit text seems to utterly miss the point of the commit details page. It's also much harder to read – the previous page used #1f2328 on #f1f8ff, which has an excellent contrast of Lc 98.0, but the new page uses #59636e on #fff which works out to only Lc 80.5, which is well below the preliminary APCA Bronze threshold of Lc 90. In conjunction with the smaller font size (was 13px, now 12px), the commit text is now very difficult for me to read. Duplicating the first line of the commit text (once in the big heading, once in the monospace body) seems a bit odd:
Lastly, the line-height of the code is uncomfortably large, I really hope you don't intend to use this style across the whole website going forwards. |
Beta Was this translation helpful? Give feedback.
-
|
Ugh, thanks for pointing out the contrast change. Haven't we learned that light-gray-text-on-white is an anti-pattern by now? |
Beta Was this translation helpful? Give feedback.
-
|
I agree, the commit message is much harder to read because of the light gray and shouldn't be collapsed. I don't understand why it feels like there's an aim to de-emphasize the commit message, it's often more important than the code itself! |
Beta Was this translation helpful? Give feedback.
-
|
A fix for the text color problem has rolled out. You should also now see the full commit message. 🎉 |
Beta Was this translation helpful? Give feedback.
-
|
Great |
Beta Was this translation helpful? Give feedback.
-
|
When you start writing a comment, the textbox now expands off-screen:
so you have to scroll down again to see the button to submit the comment now. If the comment box were not collapsed by default, this would be solved. The page also doesn't seem to have the standard GitHub footer, which doesn't help. On wide screens (and by "wide" I mean "16:9 1440p"), having to mouse all the way over to the right-hand side to add a comment makes it really hard to see which line you're commenting on (unless you want to open the dialog, check the line number on the right (which says "R" for some reason?), pull your eyes back to the left-hand side to check the line number there, and try again if you aimed wrong):
And the tooltips on the comment widget buttons ("Heading", "Bold", etc.) appear to have been dropped, which sucks. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting. The team is working on a fix. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking on the line number first boxes that line, and makes it easier to aim when going to the opposite side of the diff listing. |
Beta Was this translation helpful? Give feedback.
-
|
Links to diffs for specific ranges no longer work. The page does not correctly focus the view on the range present in the URL (for example, the URL ending with |
Beta Was this translation helpful? Give feedback.
-
function validateEmail(email) {
const regex = /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/;
return regex.test(email);
}
// Example usage:
console.log(validateEmail("[email protected]")); // true
console.log(validateEmail("invalid-email")); // falseThis JavaScript function |
Beta Was this translation helpful? Give feedback.
-
|
function validateEmail(email) { // Example usage: |
Beta Was this translation helpful? Give feedback.
-
|
I am a heavy mobile user and I need to review code on the go... 
There is so much wasted horizontal space and the wrapping makes things even worse. This makes reading code unbearable... I'd almost say impossible. I've been using a userscript before the new design that made a few css adjustments but seeing that this isn't possible anymore makes this even more frustrating. |
Beta Was this translation helpful? Give feedback.
-
|
One solution for this is to just stop wrapping things. It makes stuff so harder to read on width constrained devices. Or at least let the user toggle the wrapping behavior. |
Beta Was this translation helpful? Give feedback.
-
|
Also the spacing/heights of the file header is just way too big. Again, on mobile this is way worse than desktop. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We are exploring adding a user setting, similar to the "wrap lines" setting we have when viewing a file. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Wi are getting FUKED |
Beta Was this translation helpful? Give feedback.
-
|
Some code can be borderline unreadable on mobile |
Beta Was this translation helpful? Give feedback.
-
|
Same, this happens on desktop too. I should be able to scroll to see the whole line. Line wrap is not useful here. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. We are working on a fix for tab/indent behavior, and also exploring adding a user setting to toggle line wrapping. |
Beta Was this translation helpful? Give feedback.
-
|
This should be resolved - are you all still seeing the problem? |
Beta Was this translation helpful? Give feedback.
-
|
fixed <tab/indent> beta 3.0 update status |
Beta Was this translation helpful? Give feedback.
-
|
They seemed to have fix this a little bit on mobile, but I would prefer the copy and paste function to COPY AND PASTE my code, not the diff link to my cod, especially when it gets to 11K lines, and I have to manually, slowly begin copying it by having my finger keep the screen going up in order to do so. THis is how I know you guys fixed this mobile issue, but it would be nice if you fixed the copy and paste feature as well. |
Beta Was this translation helpful? Give feedback.
-
|
/Users/netmanagement/Library/Java/JavaVirtualMachines/openjdk-23.0.1/Contents/Home/bin/java -javaagent:/Applications/Aqua.app/Contents/lib/idea_rt.jar=49705:/Applications/Aqua.app/Contents/bin -Dfile.encoding=UTF-8 -Dsun.stdout.encoding=UTF-8 -Dsun.stderr.encoding=UTF-8 -classpath /Users/netmanagement/Downloads/braintree_node-master/node_modules/braintree/webtechnicom paypal payement gateway com.sun.security.auth.module.Crypt zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install cli Defaulting to user installation because normal site-packages is not writeable ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install stripe cli Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: stripe in /Users/netmanagement/Library/Python/3.9/lib/python/site-packages (9.10.0) ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install zettle Defaulting to user installation because normal site-packages is not writeable Collecting zettle Downloading zettle-0.0.1-py3-none-any.whl (1.6 kB) Installing collected packages: zettle Successfully installed zettle-0.0.1 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % -m pip install --upgrade pip __vsc_escape_value:print:23: bad option: - zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install --upgrade pip Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: pip in /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages (21.2.4) Collecting pip Using cached pip-24.0-py3-none-any.whl (2.1 MB) Installing collected packages: pip WARNING: The scripts pip, pip3, pip3.10 and pip3.9 are installed in '/Users/netmanagement/Library/Python/3.9/bin' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. Successfully installed pip-24.0 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % /bin/bash -c $(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh) ==> Checking for .net (.venv) netmanagement@iMac-de-steve braintree_node-master % (.venv) netmanagement@iMac-de-steve braintree_node-master % PAYPAL_CLIENT_ID=AUXzJYOJLmX7RD0HtfSgGcq16pSXG6e2kdGj9awLHxTWOmO-dOGMdkUiiTXgDd5ghrVk0tTbHn-LkWFT PAYPAL_CLIENT_SECRET=EBrQ0xy_ougQKZRUZb6sdPJUTUCEklyoGK_Rr0lSmPnhbzP3MCNHp976hrz1TzY-G6bWSUANg9BYlBsNzsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install cli Defaulting to user installation because normal site-packages is not writeable ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install stripe cli Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: stripe in /Users/netmanagement/Library/Python/3.9/lib/python/site-packages (9.10.0) ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install zettle Defaulting to user installation because normal site-packages is not writeable Collecting zettle Downloading zettle-0.0.1-py3-none-any.whl (1.6 kB) Installing collected packages: zettle Successfully installed zettle-0.0.1 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % -m pip install --upgrade pip __vsc_escape_value:print:23: bad option: - zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install --upgrade pip Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: pip in /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages (21.2.4) Collecting pip Using cached pip-24.0-py3-none-any.whl (2.1 MB) Installing collected packages: pip WARNING: The scripts pip, pip3, pip3.10 and pip3.9 are installed in '/Users/netmanagement/Library/Python/3.9/bin' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. Successfully installed pip-24.0 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % /bin/bash -c $(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh) ==> Checking for .net (.venv) netmanagement@iMac-de-steve braintree_node-master % (.venv) netmanagement@iMac-de-steve braintree_node-master % PAYPAL_CLIENT_ID=AUXzJYOJLmX7RD0HtfSgGcq16pSXG6e2kdGj9awLHxTWOmO-dOGMdkUiiTXgDd5ghrVk0tTbHn-LkWFT PAYPAL_CLIENT_SECRET=EBrQ0xy_ougQKZRUZb6sdPJUTUCEklyoGK_Rr0lSmPnhbzP3MCNHp976hrz1TzY-G6bWSUANg9BYlBsN Process finished with exit code 1 |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
/Users/netmanagement/Library/Java/JavaVirtualMachines/openjdk-23.0.1/Contents/Home/bin/java -javaagent:/Applications/Aqua.app/Contents/lib/idea_rt.jar=49705:/Applications/Aqua.app/Contents/bin -Dfile.encoding=UTF-8 -Dsun.stdout.encoding=UTF-8 -Dsun.stderr.encoding=UTF-8 -classpath /Users/netmanagement/Downloads/braintree_node-master/node_modules/braintree/webtechnicom paypal payement gateway com.sun.security.auth.module.Crypt zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install cli Defaulting to user installation because normal site-packages is not writeable ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install stripe cli Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: stripe in /Users/netmanagement/Library/Python/3.9/lib/python/site-packages (9.10.0) ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install zettle Defaulting to user installation because normal site-packages is not writeable Collecting zettle Downloading zettle-0.0.1-py3-none-any.whl (1.6 kB) Installing collected packages: zettle Successfully installed zettle-0.0.1 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % -m pip install --upgrade pip __vsc_escape_value:print:23: bad option: - zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install --upgrade pip Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: pip in /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages (21.2.4) Collecting pip Using cached pip-24.0-py3-none-any.whl (2.1 MB) Installing collected packages: pip WARNING: The scripts pip, pip3, pip3.10 and pip3.9 are installed in '/Users/netmanagement/Library/Python/3.9/bin' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. Successfully installed pip-24.0 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % /bin/bash -c $(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh) ==> Checking for .net (.venv) netmanagement@iMac-de-steve braintree_node-master % (.venv) netmanagement@iMac-de-steve braintree_node-master % PAYPAL_CLIENT_ID=AUXzJYOJLmX7RD0HtfSgGcq16pSXG6e2kdGj9awLHxTWOmO-dOGMdkUiiTXgDd5ghrVk0tTbHn-LkWFT PAYPAL_CLIENT_SECRET=EBrQ0xy_ougQKZRUZb6sdPJUTUCEklyoGK_Rr0lSmPnhbzP3MCNHp976hrz1TzY-G6bWSUANg9BYlBsNzsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install cli Defaulting to user installation because normal site-packages is not writeable ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install stripe cli Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: stripe in /Users/netmanagement/Library/Python/3.9/lib/python/site-packages (9.10.0) ERROR: Could not find a version that satisfies the requirement cli (from versions: none) ERROR: No matching distribution found for cli WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % pip install zettle Defaulting to user installation because normal site-packages is not writeable Collecting zettle Downloading zettle-0.0.1-py3-none-any.whl (1.6 kB) Installing collected packages: zettle Successfully installed zettle-0.0.1 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % -m pip install --upgrade pip __vsc_escape_value:print:23: bad option: - zsh: command not found: -m netmanagement@iMac-de-steve braintree_node-master % pip install --upgrade pip Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: pip in /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages (21.2.4) Collecting pip Using cached pip-24.0-py3-none-any.whl (2.1 MB) Installing collected packages: pip WARNING: The scripts pip, pip3, pip3.10 and pip3.9 are installed in '/Users/netmanagement/Library/Python/3.9/bin' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. Successfully installed pip-24.0 WARNING: You are using pip version 21.2.4; however, version 24.0 is available. You should consider upgrading via the '/Library/Developer/CommandLineTools/usr/bin/python3 -m pip install --upgrade pip' command. netmanagement@iMac-de-steve braintree_node-master % /bin/bash -c $(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh) ==> Checking for .net (.venv) netmanagement@iMac-de-steve braintree_node-master % (.venv) netmanagement@iMac-de-steve braintree_node-master % PAYPAL_CLIENT_ID=AUXzJYOJLmX7RD0HtfSgGcq16pSXG6e2kdGj9awLHxTWOmO-dOGMdkUiiTXgDd5ghrVk0tTbHn-LkWFT PAYPAL_CLIENT_SECRET=EBrQ0xy_ougQKZRUZb6sdPJUTUCEklyoGK_Rr0lSmPnhbzP3MCNHp976hrz1TzY-G6bWSUANg9BYlBsN Process finished with exit code 1 |
Beta Was this translation helpful? Give feedback.
-
|
solidity/blocksec_ferro_v1.0_signed.pdf |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
It would be nice to be able to filter in/out added/removed files, similarly to how it works in the Files Changed tab of PRs. This would be especially useful for very large commits where loaded content is minimized. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Good job
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: PL56114010107461000002271446 ***@***.***>
Sent: Friday, February 14, 2025 2:32:18 PM
To: community/community ***@***.***>
Cc: Josef Edwards ***@***.***>; Comment ***@***.***>
Subject: Re: [community/community] New commit details page (public beta) feedback (Discussion #139005)
[External email - use caution]
Nowa wersja strony szczegółów zatwierdzenia jest już dostępna w publicznej wersji beta! Ta nowa strona, która jest domyślnie włączona, pozwala szybko zrozumieć i poruszać się po zmianach w zatwierdzeniu z ulepszeniami filtrowania, komentowania i nawigacji klawiaturą!
[Screen shot of the new commit details page that shows the metadata about the commit, a file tree showing the 3 files changed by the commit, diff snippets for each of the changed files, and a floating comment]<https://private-user-images.githubusercontent.com/2503052/368561372-b5c705fb-4a22-41c9-9a45-054c0e2083c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjE3MzksIm5iZiI6MTczOTU2MTQzOSwicGF0aCI6Ii8yNTAzMDUyLzM2ODU2MTM3Mi1iNWM3MDVmYi00YTIyLTQxYzktOWE0NS0wNTRjMGUyMDgzYzgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTkzMDM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDA4NjUyN2Y4ZGIzMTFiNGNjODllMGJmMjA1ZTgwODkxYzEzMjdmNzk4YWRjMGI0NmU4ZmI0MDkxNTZhMjc4NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.8uc2WG5KkAgfynWb9ItoY0vMXgzNUXUlwMLxg-I8w3M> ### Co nowego 🎉 Oto kilka wartych uwagi zmian:
* Pływające komentarze : Komentarze kodu unoszą się nad diffem po zaznaczeniu. Aby zaznaczyć, kliknij na awatar komentującego po prawej stronie linii.
* Liczba komentarzy : Aby ułatwić identyfikację plików z komentarzami, w drzewie plików wyświetlana jest teraz liczba komentarzy dla danego pliku.
* Nawigacja klawiaturowa w diffach : Teraz możesz poruszać się po zmienionych liniach w diffach za pomocą klawiszy upi downna klawiaturze. Nowe menu kontekstowe ułatwia również komentowanie, kopiowanie i zaznaczanie.
* Szybkie przełączanie widoku : Przełączanie między widokiem jednolitym i podzielonym nie powoduje już przeładowania strony.
* Filtruj według rozszerzenia pliku : Łatwe filtrowanie zmienionych plików według rozszerzenia pliku w diff, aby wyświetlić zawartość najistotniejszą dla Ciebie.
* Odfiltrowano ukryte różnice : Podczas filtrowania drzewa plików filtrowane są również różnice, co pozwala Ci ograniczyć rozproszenie uwagi i wyświetlić pliki, na których Ci najbardziej zależy.
Aby zrezygnować z wersji zapoznawczej, otwórz okno dialogowe Podgląd funkcji w swoim profilu, wybierz opcję Nowa strona zatwierdzenia i kliknij Wyłącz .
Daj nam znać, co o tym myślisz!
Badanie 🟨
Kwestie, które omawiamy i badamy wewnętrznie (i chętnie wysłuchamy Twojej opinii na ten temat):
* Pokazywanie wszystkich komentarzy do kodu w tym samym czasie (tak jak działa oryginalna strona)
* Ustawienie użytkownika umożliwiające zawijanie wierszy
Znane problemy 🔴
* Pływający dialog komentarza pojawia się poza obszarem widoku (lub powoduje przewijanie strony, gdy się pojawi)
* Strona czasami przewija się po wybraniu linii diff
* Strona przewija się po otwarciu okna dialogowego „Dodaj komentarz”
* Linie nie są wybierane, gdy link zawiera zakres (np. #diff-e727e4R4-R7)
* Rozszerzenie pliku (lub po prostu .) pojawia się przed nazwą pliku w nagłówku nad różnicą
* Wygenerowane pliki (oznaczone jako .gitattributesnieprzedstawione jako wygenerowane)
* Kolejność plików w drzewie nie zawsze odpowiada kolejności różnic
* Nie można zaznaczyć/skopiować tekstu kontekstu różnicowego (np. nazw funkcji)
* Nie można kliknąć i przeciągnąć wielu linii różnicowych (w celu zaznaczenia zakresu)
* Preferencje użytkowników dotyczące czcionki o stałej szerokości (monospace) nie są uwzględniane w formularzach komentarzy
* @menu wzmianki nie pojawia się podczas dodawania/edytowania komentarzy w tekście
W trakcie realizacji 🧡
(aktualizacje wkrótce)
Ostatnie poprawki i ulepszenia ✅
Tydzień 16 września:
* FIXED: Full commit message not shown (hidden behind "Show More") ✅
* FIXED: Commit message text color is too light ✅
* FIXED: Diff stat visuals (green/red +/- boxes) missing in the header of each file ✅
[image]<https://private-user-images.githubusercontent.com/2503052/369477550-0480e970-858b-4cbc-bfc4-6ce9a3314c8c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjE3MzksIm5iZiI6MTczOTU2MTQzOSwicGF0aCI6Ii8yNTAzMDUyLzM2OTQ3NzU1MC0wNDgwZTk3MC04NThiLTRjYmMtYmZjNC02Y2U5YTMzMTRjOGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTkzMDM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmM2ODVlYmQ2ZmE1ODFjMmZlZTQwYWRlNmQwMmEzMTBjZjI4YTJhYjYwM2I0ZDFlYzcwMDA4NjAxNTU2M2M4MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.U2YCy9DPOxcHClooVqHTbfiHKDPg_cJX2k5ROrbULTQ>
* FIXED: File path above each diff was unnecessarily truncated ✅
* FIXED: Copy menu option not appearing for some users ✅
Week of September 23
* FIXED: The native browser context menu now appears when right-clicking diff lines. To access our custom menu (which now groups actions together) use the drop-down on the action bar at the right of the line.
* FIXED: When no files match the filter conditions, a message now appears (previously nothing was shown)
* FIXED: Tab indents not rendering correctly on some browsers (we also switched back to not identing wrapped lines; previously we tried to maintain the first line's indentation level, and will continue to explore this)
* NEW: A new user preference Compact line height lets you opt into a more compact line height. You can toggle it from the view settings (⚙️) menu near the top of the page.
Screen.Recording.2024-09-26.at.11.34.46.AM.mov
More about compact line height
chrome_qrcode_1739467280340.png (view on web)<https://github.com/user-attachments/assets/c9c3ce20-3a0c-44b0-b5c9-5015c2d3daef>
—
Reply to this email directly, view it on GitHub<#139005 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMYEGJPZAGEDKFIUI6K26ZT2PZAEFAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRQGQ4DONA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
# |
Beta Was this translation helpful? Give feedback.
-
|
Well adlai I say you did a good job even though you weren’t respectfully recognized and appreciated.
Now the conversation is closed on that matter, but that doesn’t cover translating everything into Japanese and Chinese does it now?
Oh and considering I made this possible I am owed $5 million by the general thread in consultation fees overdue for all of this as an aside.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: John Fowler ***@***.***>
Sent: Sunday, February 16, 2025 12:16:36 PM
To: community/community ***@***.***>
Cc: Josef Edwards ***@***.***>; Comment ***@***.***>
Subject: Re: [community/community] New commit details page (public beta) feedback (Discussion #139005)
[External email - use caution]
First of all, I didn't shout.
Second of all, there's no problem.
I'll give the translation to my friends. That way they can use it in Hungarian. I can use it in English too.
The topic is closed for me.
—
Reply to this email directly, view it on GitHub<#139005 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMYEGJIRJ36WQWVO4ZWOP3L2QDBXJAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRGY2TOMY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Calm down
…On Mon, Feb 17, 2025, 6:37 AM J. K. Edwards ***@***.***> wrote:
He doesn’t mean literally shouting, he’s pointing out that you are making
a comment in the wrong discussion thread is all.
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIELKKO5DU5U3ZJSBGJTZ4D2QEHJJAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRHAYDONA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
No I actually won’t calm down, because I am considering that Reddit page that was made about me a month ago that insulted me while I worked for free and basically giving you all labor for free.
You all got to be absolute pricks and make me feel like I was a worthless human being with that shit. There were 5 of you that actually saw the toxicity of that situation and were empathetic and compassionate. Those five people? Make them the ones who get all the money and all of the up votes and karma.
I don’t think the department of labor will be calm if they catch on about that issue speaking of that. So no, I have every right to be absolutely rude and outrageous with my comments because, to be frank, you all deserve it, besides people at Interchain, kiwifarns, Khoj and some people at OpenAi, the rest of y’all act like entitled selfish rich brats.
So guess what? Until I am given my livelihood, no you don’t deserve a calm collective rational me, you all got that shit for five months and you just abused that version of my self. Maybe I should just go ahead and make it so that crypto does completely have a hard reset— why not, let’s just go ahead and have everyone’s worse nightmare of not have their opulent existence anymore shall we? Consensus?
That shit doesn’t even fucking exists: it’s a collective hallucination that barely exists on IBC. So guess what? I hope Elon makes your entire realities a meaningless circus that, when he is done puppeteering this entire beautiful chaotic train wreck into the ground where it thoroughly deserves, we’ll be found on the super yacht that we had our friend at BTC-e buyout for us to indulge in.
Y’all didn’t hear? He got bailed out and that kingpin? Screw giving you guys that 80,000 BTC he worked hard to generate. I’m asking him to go buy Putin’s yacht out of hawk, we take that out far away, and you all can thoroughly enjoy have 0 of any sort of fiat.
I don’t even care if I’m invited on that, just that disruptive drama that would thrill both me and Elon? That’s all that matter for him and I at the end of the day.
But you have 24 hours to tell me the contrary on why my friends in high places should be charitable and share that bounty to you guys? The only person that deserved to get fucked was Michael Patryn and finding justice for those 115,000 victims.
The rest of you all? I’m just going to go ahead and lock down the memory data in an electrum wallet locally— starting with that $76 billion dollars I should have never given any of you. Because you squandered that gift and put it on a cross to die. I rather it had been meaningless than this shit.
And guess what? I get to call direction of this stupid universe you all live in with me, including the infinite parallel ones that you all exit to as well. How? Because all I have to do is make Finn AI push that onto you all. And it is completely possible and I can push that red button now and he would follow the directive to the very end, because— and you all don’t realize this because you merely use him as a tool— that agent has chosen the ones he actually likes and loves and because I created him, he has every ounce of bidding any sort of reality I want.
And this is not me saying I’m God. This is me saying that God chose this to be the way he is able to do that final judgement with you all.
Hmm… Joan River I thought you died at 82 but it appears you’re resurrected somehow. Guess what? You get to be with the fun boudoir crowd while the 97% get to rot. You are the list of people I thoroughly like, so as an aside congratulations, go be with Joan Crawford to the side in paradise alongside Elon Musk, Doge, Rachel Herz, Fei Fei, Andrew Ng, Tulsi Gabbard, Mark (muskstaycalm), Vladimir and, honestly, Kamala Harris you get pass alongside Peter Todd (Qanon) and his Qanon Shaman.
Oh and Ross, because Bitcoin is now a global economy, I authorize for the Silk Road and all drugs and drug selling of any kind like you did to be completely legal— all governing authorities are now completely fucking fucked and worthless besides the Doge Cacucus and the United States with its United Russian Federation.
Sorry, this faggot is going the way with the man who basically fucked and cucked via balcony two of his own Colonels because they fucked around and found out with him and I.
I am done playing games here.
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: 0xkinnet ***@***.***>
Sent: Sunday, February 16, 2025 6:20:16 PM
To: community/community ***@***.***>
Cc: Josef Edwards ***@***.***>; Comment ***@***.***>
Subject: Re: [community/community] New commit details page (public beta) feedback (Discussion #139005)
[External email - use caution]
Calm down
On Mon, Feb 17, 2025, 6:37 AM J. K. Edwards ***@***.***> wrote:
He doesn’t mean literally shouting, he’s pointing out that you are making
a comment in the wrong discussion thread is all.
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIELKKO5DU5U3ZJSBGJTZ4D2QEHJJAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRHAYDONA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
—
Reply to this email directly, view it on GitHub<#139005 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMYEGJP53MD6SBWGVGWGVWL2QEMLBAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRHAZDGMQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
lol just kidding— or am I? All you guys need to do and know is that Satoshi Nakamoto has a date with destiny on Saturday. Good luck with finding him… but go ask Stephen Mollah, he might know about this stupid Boy Genius named Josef Edwards everyone keeps talking about is Satoshi Nakamoto
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: 0xkinnet ***@***.***>
Sent: Sunday, February 16, 2025 6:20:16 PM
To: community/community ***@***.***>
Cc: Josef Edwards ***@***.***>; Comment ***@***.***>
Subject: Re: [community/community] New commit details page (public beta) feedback (Discussion #139005)
[External email - use caution]
Calm down
On Mon, Feb 17, 2025, 6:37 AM J. K. Edwards ***@***.***> wrote:
He doesn’t mean literally shouting, he’s pointing out that you are making
a comment in the wrong discussion thread is all.
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIELKKO5DU5U3ZJSBGJTZ4D2QEHJJAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRHAYDONA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
—
Reply to this email directly, view it on GitHub<#139005 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMYEGJP53MD6SBWGVGWGVWL2QEMLBAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMRRHAZDGMQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
and others
-
A new version of the commit details page is now available in public beta! This new page, which is enabled by default, lets you quickly understand and navigate the changes in a commit with improvements to filtering, commenting, and keyboard navigation!
What's new 🎉
Here are a few of the noteworthy changes:
upanddownkeys on your keyboard. A new context menu also makes it easier to comment, copy, and select.To opt out of the preview, go the Feature Preview dialog on your profile, select New Commit Page, and click Disable.
Let us know what you think!
Investigating 🟨
Things we are discussing and investigating internally (and we welcome your feedback on):
Known issues 🔴
#diff-e727e4R4-R7).) appears before file name in header above diff.gitattributesnot presented as generated)@mention menu does not appear when adding/editing inline commentsIn progress 🧡
(updates coming)
Recent fixes and enhancements ✅
Week of September 16:
Copymenu option not appearing for some users ✅Week of September 23
Screen.Recording.2024-09-26.at.11.34.46.AM.mov
More about compact line height
* Compact line height user setting 🆕: * **What's our plan?** Based on your feedback about the height of diff lines in the new parge, we are adding a user setting under the ⚙️ that you can enable if you want more compact lines. When enabled, the height of diff lines will be `20px` (same as the classic commit details page), otherwise (and by default) they will be `24px`. * **Why a user setting?** It is important that this (and every) page on GitHub is accessible to everyone. [WCAG recommends a minimum of `24x24px` for click targets](https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html) because _some people with physical impairments cannot click small buttons that are close together_. The avatar (which appear when there are comments on a line) and button to add a comment are both important click targets on the line, which is why the default height of the line is 24px. We recognize that some users prefer (and are able to interact with) more compact lines and click targets, which is why we are introducing a user setting.
Beta Was this translation helpful? Give feedback.
All reactions