feat: Update AWS SDK v2 to v3 [WIP] #528
Conversation
src/util/aws-util.ts
Outdated
| // save the credentialsProvider for any of the services we initialize | ||
| AwsUtil.credentialsProvider = provider; | ||
|
|
||
| // oc: not sure if this is needed, my guess is not |
There was a problem hiding this comment.
I'm not sure. Isn't it necessary to pick up sso credentials for example?
To do this, specify a credential process in the shared AWS config file or the shared credentials file. If the AWS_SDK_LOAD_CONFIG environment variable is set to a truthy value, the SDK will prefer the process specified in the config file over the process specified in the credentials file (if any).
There was a problem hiding this comment.
hmm.. the default credentials provider seems to be capable of dealing with all of it. we could just try to not set it and see what happens
src/util/aws-util.ts
Outdated
| public static async Initialize(credentials?: Provider<AwsCredentialIdentity>): Promise<void> { | ||
|
|
||
| // if no credentials(provider) was passed in this method, we use the default | ||
| const provider = credentials ?? defaultProvider({ |
There was a problem hiding this comment.
is this custom credentials provider strictly here for testing purposes? I can't find anywhere in the code where it is invoked with a customer credentials provider
There was a problem hiding this comment.
we used to do that for GovCloud (see here)
…-formation-cli into feat/update_aws_sdk_v3
…-formation-cli into feat/update_aws_sdk_v3
…-formation-cli into feat/update_aws_sdk_v3
OlafConijn
force-pushed
the
feat/update_aws_sdk_v3
branch
from
be080e7 to
4860a81
Compare
Hi all, I started working on this a while ago, but since I had encountered one road block that I wasn't able to upgrade yet. The authentication part. I hope this community can give me a hand to complete this PR and we can finally upgrade to v3