Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(minor): [sc-2205] Merge upstream & use our fork of librdkafka #19

Closed
wants to merge 13 commits into from

Conversation

axelandersson
Copy link

Description

Changed librdkafka to https://github.com/ordo-one/librdkafka.

Updated from https://github.com/swift-server/swift-kafka-client and merged changes.

Fixed these errors by removing the finishOnDeinit parameter. Seems this parameter was removed. Not sure if this is correct.

/Users/axel/GitHub/swift-kafka-client/Sources/Kafka/KafkaConsumer.swift:192:29: error: extra argument 'finishOnDeinit' in call
            finishOnDeinit: true,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/Users/axel/GitHub/swift-kafka-client/Sources/Kafka/KafkaConsumer.swift:298:29: error: extra argument 'finishOnDeinit' in call
            finishOnDeinit: true,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/Users/axel/GitHub/swift-kafka-client/Sources/Kafka/KafkaProducer.swift:192:29: error: extra argument 'finishOnDeinit' in call
            finishOnDeinit: true,

How Has This Been Tested?

swift test

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

This pull request has been linked to Shortcut Story #2205: Create iOS/iPad target and make it buildable.

@axelandersson axelandersson changed the title Merge upstream & use our fork of librdkafka chore(minor): [sc-2205] Merge upstream & use our fork of librdkafka Nov 27, 2023
@axelandersson axelandersson changed the base branch from main to next November 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants