Add destination field to batch #2701

raphjaph · 2023-11-19T22:12:54Z

Tests:

with some destinations set and others not
if shared-output mode then destination field not allowed -> should fail
invalid address set in destination

…-to-field-to-batch

batch.yaml

src/subcommand/wallet/inscribe/batch.rs

tests/wallet/inscribe.rs

src/subcommand/wallet/inscribe/batch.rs

…ls/ord into add-destination-to-field-to-batch

casey

LGTM!

* Fix lost sats bug (ordinals#2666) * Add Hindi version of handbook (ordinals#2648) * Remove Index::index_block_inscription_numbers (ordinals#2667) * Hide protocol inscriptions (ordinals#2674) * Don't color links in headers (ordinals#2678) * Add inscription charms (ordinals#2681) * Group rune server tests (ordinals#2685) * Add inscription compression (ordinals#1713) * Fix media table formatting (ordinals#2686) * Update schema version for charms (ordinals#2687) * Fix unbound outpoint server error (ordinals#2479) * Add binary media type (ordinals#2671) * Clean up install.sh (ordinals#2669) * Add /collections Page (ordinals#2561) * Preview font inscriptions (ordinals#2692) * Only load used language highlight module in code preview (ordinals#2696) * Only try to create the database if it wasn't found (ordinals#2703) * Move postage into batch file (ordinals#2705) * Add destination field to batch (ordinals#2701) * Use sequence numbers database keys (ordinals#2664) * Update redb to 1.4.0 (ordinals#2714) * Refactor inscriptions paginations (ordinals#2715) * Display table stats in `ord index info` (ordinals#2711) * Use redb's recovery callback API (ordinals#2584) * Allow setting CSP origin (ordinals#2708) * Remove default file path from `ord index export --tsv` (ordinals#2717) * Use icons in nav bar (ordinals#2722) * Add Debian packaging instructions (ordinals#2725) * Add Homebrew install instructions to readme (ordinals#2726) * Add sat recursive endpoints with index and pagination (ordinals#2680) * Only accept sat number in recursive endpoint (ordinals#2732) * Fix typo in docs/src/inscriptions/metadata.md (ordinals#2731) * Add docs for metadata recursive endpoint (ordinals#2734) * Remove `RUNE` from <h1> on /rune (ordinals#2728) * Add /r/children recursive endpoint (ordinals#2431) * Add docs and examples for sat recursive endpoint (ordinals#2735) * Ignore flaky test (ordinals#2742) * Update docs to include all fields, including content-encoding (ordinals#2740) * Add docs for child recursive endpoint (ordinals#2743) * Hide JSON and .btc (ordinals#2744) * Release 0.12.0 (ordinals#2746) --------- Co-authored-by: raph <[email protected]> Co-authored-by: duttydeedz <[email protected]> Co-authored-by: Casey Rodarmor <[email protected]> Co-authored-by: liam <[email protected]> Co-authored-by: Eloc <[email protected]> Co-authored-by: Julian Eager <[email protected]> Co-authored-by: ordinally <[email protected]> Co-authored-by: Christopher Berner <[email protected]> Co-authored-by: Rijndael <[email protected]> Co-authored-by: vuittont60 <[email protected]>

* Fix lost sats bug (ordinals#2666) * Add Hindi version of handbook (ordinals#2648) * Remove Index::index_block_inscription_numbers (ordinals#2667) * Hide protocol inscriptions (ordinals#2674) * Don't color links in headers (ordinals#2678) * Add inscription charms (ordinals#2681) * Group rune server tests (ordinals#2685) * Add inscription compression (ordinals#1713) * Fix media table formatting (ordinals#2686) * Update schema version for charms (ordinals#2687) * Fix unbound outpoint server error (ordinals#2479) * Add binary media type (ordinals#2671) * Clean up install.sh (ordinals#2669) * Add /collections Page (ordinals#2561) * Preview font inscriptions (ordinals#2692) * Only load used language highlight module in code preview (ordinals#2696) * Only try to create the database if it wasn't found (ordinals#2703) * Move postage into batch file (ordinals#2705) * Add destination field to batch (ordinals#2701) * Use sequence numbers database keys (ordinals#2664) * Update redb to 1.4.0 (ordinals#2714) * Refactor inscriptions paginations (ordinals#2715) * Display table stats in `ord index info` (ordinals#2711) * Use redb's recovery callback API (ordinals#2584) * Allow setting CSP origin (ordinals#2708) * Remove default file path from `ord index export --tsv` (ordinals#2717) * Use icons in nav bar (ordinals#2722) * Add Debian packaging instructions (ordinals#2725) * Add Homebrew install instructions to readme (ordinals#2726) * Add sat recursive endpoints with index and pagination (ordinals#2680) * Only accept sat number in recursive endpoint (ordinals#2732) * Fix typo in docs/src/inscriptions/metadata.md (ordinals#2731) * Add docs for metadata recursive endpoint (ordinals#2734) * Remove `RUNE` from <h1> on /rune (ordinals#2728) * Add /r/children recursive endpoint (ordinals#2431) * Add docs and examples for sat recursive endpoint (ordinals#2735) * Ignore flaky test (ordinals#2742) * Update docs to include all fields, including content-encoding (ordinals#2740) * Add docs for child recursive endpoint (ordinals#2743) * Hide JSON and .btc (ordinals#2744) * Release 0.12.0 (ordinals#2746) * Hide all text (ordinals#2753) * Add batch to preview command (ordinals#2752) * Add stuttering curse (ordinals#2745) * Batch inscribe on same sat (ordinals#2749) * Allow setting the sat to inscribe (ordinals#2765) * Select further away coins which meet target (ordinals#2724) * Fix typos (ordinals#2768) * Add ability to specify sat to batch inscribe (ordinals#2770) * Add commands to etch and list runes (ordinals#2544) * Set CSP origin in deploy script (ordinals#2764) Co-authored-by: raph <[email protected]> * Add `public` to /content Cache-Control headers (ordinals#2773) * Release 0.12.1 (ordinals#2776) * Bless cursed inscriptions after Jubilee height (ordinals#2656) * Hide /content/<INSCRIPTION_ID> HTML inscriptions (ordinals#2778) * Release 0.12.2 (ordinals#2780) * fix(test): error test from version 0.12.2 --------- Co-authored-by: raph <[email protected]> Co-authored-by: duttydeedz <[email protected]> Co-authored-by: Casey Rodarmor <[email protected]> Co-authored-by: liam <[email protected]> Co-authored-by: Eloc <[email protected]> Co-authored-by: Julian Eager <[email protected]> Co-authored-by: ordinally <[email protected]> Co-authored-by: Christopher Berner <[email protected]> Co-authored-by: Rijndael <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: gmart7t2 <[email protected]> Co-authored-by: xiaolou86 <[email protected]>

raphjaph added 2 commits November 19, 2023 19:12

Add destination field to Batch

d2429bf

Some tests

459f6f7

raphjaph marked this pull request as ready for review November 19, 2023 22:49

raphjaph requested a review from casey November 19, 2023 22:49

Merge branch 'master' of github.com:ordinals/ord into add-destination…

a80f3c9

…-to-field-to-batch

casey requested changes Nov 20, 2023

View reviewed changes

raphjaph added 3 commits November 20, 2023 19:32

merging

87c18ee

address some code review comments

934c4ca

remove hash set

b42c429

raphjaph mentioned this pull request Nov 21, 2023

Is there a detailed tutorial on Batch Inscribing? #2661

Closed

casey reviewed Nov 21, 2023

View reviewed changes

src/subcommand/wallet/inscribe/batch.rs Outdated Show resolved Hide resolved

Update src/subcommand/wallet/inscribe/batch.rs

1088851

casey reviewed Nov 21, 2023

View reviewed changes

src/subcommand/wallet/inscribe/batch.rs Outdated Show resolved Hide resolved

raphjaph added 2 commits November 20, 2023 23:12

clean up logic

9847dc1

Merge branch 'add-destination-to-field-to-batch' of github.com:ordina…

33d697c

…ls/ord into add-destination-to-field-to-batch

casey approved these changes Nov 21, 2023

View reviewed changes

raphjaph enabled auto-merge (squash) November 21, 2023 02:15

quick fix

77ec46e

raphjaph merged commit dd56f2c into master Nov 21, 2023
6 checks passed

raphjaph deleted the add-destination-to-field-to-batch branch November 21, 2023 02:22

elocremarc mentioned this pull request Nov 24, 2023

Ord batch inscribe send to wallet Inscriptions not showing in unisat. unisat-wallet/extension#114

Closed

popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025

Add destination field to batch (ordinals#2701)

d33f481

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add destination field to batch #2701

Add destination field to batch #2701

raphjaph commented Nov 19, 2023 •

edited

Loading

casey left a comment

Add destination field to batch #2701

Add destination field to batch #2701

Conversation

raphjaph commented Nov 19, 2023 • edited Loading

casey left a comment

Choose a reason for hiding this comment

raphjaph commented Nov 19, 2023 •

edited

Loading