-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for recurrence generators #722
Conversation
|
@@ -43,7 +43,8 @@ | |||
"rrule-rust": "^1.2.0", | |||
"sequelize": "^6.6.2", | |||
"typed-emitter": "^1.3.1", | |||
"uuid": "^8.3.2" | |||
"uuid": "^8.3.2", | |||
"lunartick-deprecated": "npm:@ordermentum/[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is interim while we transition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to dev dep.
Yeah, can remove once the solution is prod tested.
Looks reasonable to me. When you clean up lunartick, what's the leave behind unit tests that confirm rrule is set up and working as expected? |
That would be the helpers test file https://github.com/ordermentum/steveo/blob/main/packages/scheduler-sequelize/test/helpers_test.ts#L21 |
The following limitations to using lunartick for ical rules were discovered:
FREQ=MONTHLY;BYMONTHDAY=17;INTERVAL=2
)FREQ=WEEKLY;BYDAY=TH;INTERVAL=2
)BYMONTHDAY=-1
(https://github.com/ordermentum/lunartick/blob/develop/src/iterator.js#L110 shifts the date by an extra month)FREQ=WEEKLY;BYDAY=MO,WE,FR
)BYSETPOS
parameter (e.g.FREQ=DAILY;BYHOUR=8,18;BYMINUTE=30,0;BYSETPOS=1,4
)FREQ=DAILY;BYHOUR=8,18;BYMINUTE=0,30
andFREQ=DAILY;BYHOUR=8,18;BYMINUTE=30,0
- Note theBYMINUTE
prop)BYDAY
values (e.g.FREQ=MONTHLY;BYDAY=-2FR
)This PR adds some verification tests related to recurrence generator libraries