This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Feat/optional pin #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haadcode
reviewed
Nov 29, 2019
src/Store.js
Outdated
| @@ -470,14 +469,14 @@ class Store { | |||
| } | |||
| } | |||
|
|
|||
| async _addOperation (data, batchOperation, lastOperation, onProgressCallback) { | |||
| async _addOperation (data, { batchOperation, lastOperation, onProgressCallback, pin = false } = {}) { | |||
There was a problem hiding this comment.
This means the API changes and needs changes in all stores. How about instead adding pin as the last arg and keep the current API?
There was a problem hiding this comment.
@haadcode Seems to me all the stores need to be changed regardless in order to pass the options, no?
There was a problem hiding this comment.
To pass (use/enable) the option yes, but if they don't change anything, their old code still works as expected, whereas changing the API would require all dependants to change their _addOperation() calls to match the changed API.
shamb0t
force-pushed
the
feat/optional-pin
branch
from
8da9adb to
71f4a2c
Compare
remove unused arguments
shamb0t
force-pushed
the
feat/optional-pin
branch
from
71f4a2c to
0300372
Compare
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass optional arguments to
log.append