This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Support access revocation in OrbitDB access controller #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on https://github.com/orbitdb/orbit-db-access-controller-store (new repo coming along with this PR) |
|
There's still bunch of things to consider here and more tests need to be added (especially for access revocation under network partition / when DBs diverge). I think it'd make sense to reduce the complexity down a bit and remove the "capabilities" part (=various "access" levels) and consider access to write either granted or revoked. The different roles/access levels don't make much sense as they're tied to canAppend()'s functionality (eg. canAppend determines which ac level is allowed to append, so it's always a fixed level/set of levels). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add access revocation support for the OrbitDB Access Controller.
This PR, and approach in general, is still very much WIP.