feat: add firebase-access-controller #44
Conversation
| return resolve(verifiedIdentity); | ||
| } else { | ||
| // No user is signed in. | ||
| return resolve(false); |
There was a problem hiding this comment.
I did resolve(false) instead of reject(false) as this would need the developer to catch the error when canAppend is rejected, which is not good in terms of developer experience.
|
I'll add some more comments in the AccessController so that it's easy to understand how to use it. |
License: MIT Signed-off-by: Vaibhav Saini <[email protected]>
vasa-develop
force-pushed
the
feat/firebase
branch
from
855719f to
dd85be2
Compare
|
Amazing @vasa-develop! 🎉 Thank you for the PR 🙏 The code looks good to me, but would love second pair of eyes on it to confirm. What we should have is a set of tests for the AC, similar to https://github.com/orbitdb/orbit-db-access-controllers/blob/master/test/contract-access-controller.test.js and https://github.com/orbitdb/orbit-db-access-controllers/blob/master/test/contract-access-controller-integration.test.js, in order to make sure this works today and our future selves can modify things fearlessly :) @vasa-develop could you add some basic set of tests for this PR? |
|
@haadcode sure thing! I'll add the tests ASAP. |
Added a firebase-based access controller.
License: MIT
Signed-off-by: Vaibhav Saini [email protected]